Closed Bug 1131871 Opened 5 years ago Closed 5 years ago

auto_com should only uninitialize when successful

Categories

(Core :: Audio/Video, defect)

x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox38 --- fixed

People

(Reporter: dmajor, Unassigned)

Details

Attachments

(1 file)

Noticed this while reading the code. In rare cases CoInit can return other error codes; those shouldn't cause an uninit.

As a separate matter (one that I don't feel comfortable patching myself), shouldn't the caller check the hr and abort if it failed? It was that way prior to bug 848954.
Attached patch patchSplinter Review
Attachment #8562451 - Flags: review?(padenot)
Attachment #8562451 - Flags: feedback+
Comment on attachment 8562451 [details] [diff] [review]
patch

Review of attachment 8562451 [details] [diff] [review]:
-----------------------------------------------------------------

ah yeah indeed.
Attachment #8562451 - Flags: review?(padenot) → review+
https://hg.mozilla.org/mozilla-central/rev/4cea294700c1
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.