1131880 - Modify the condition to disallow PR_CONNECT_RESET_ERROR on fallback

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Masatoshi Kimura [:emk]]

Attachment: patch

On Nightly, PR_CONNECT_RESET_ERROR will be allowed if "security.tls.version.fallback-limit" is smaller than 3 due to bug 1124039.
Since I'm not going to backport the entire bug 1124039 (yet), I wrote a patch only to backport this behavior change.

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

I'm not sure I understand the motivation here - could you explain a bit more what the goal of this change is and why it's important? Thanks.

Comment 2

[Masatoshi Kimura [:emk]]

Basically what I explained in bug 1124039 comment #15:
> users (or
> hotfix addons) can disable the behavior from bug 1128763 globally in case
> too many sites are broken.

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 8562466 [details] [diff] [review]
patch

Review of attachment 8562466 [details] [diff] [review]:
-----------------------------------------------------------------

Oh, now I get it. Ok - r=me. (This is only landing on 37, right?)

Comment 4

[Masatoshi Kimura [:emk]]

(In reply to David Keeler [:keeler] (use needinfo?) from comment #3)
> (This is only landing on 37, right?)

Yes.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b7d28228e557

Comment 5

[Masatoshi Kimura [:emk]]

Comment on attachment 8562466 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: 1128763
[User impact if declined]: Users will not have an easy workaround to connect some sites. We will also have fewer choices in case we have to release a hotfix addon.
[Describe test coverage new/current, TreeHerder]: Manually tested. No existing tests are broken (see the above try run, e10s failures are expected).
[Risks and why]: Very low. Simple few changes, make Firefox more compatible with broken sites, and only <0.3% sites will be affected.
[String/UUID change made/needed]: none

Comment 6

[Masatoshi Kimura [:emk]]

Landed on inbound because bug 1124039 has been backed out.
https://hg.mozilla.org/integration/mozilla-inbound/rev/f96476302284

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f96476302284

Comment 8

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8562466 [details] [diff] [review]
patch

Aurora+

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f67ec464e569