Include repo name in autolander attachment

RESOLVED FIXED

Status

Firefox OS
Gaia::GithubBot
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: kgrandon, Assigned: kgrandon)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

4 years ago
This is to make autolander more graceful when dealing with multiple pull requests for different repos in the same bug.

As an example from a recent email bug, we currently do:

[PullReq] jrburke:bug1098289-email-request-sync to mozilla-b2g:master

There are a number of options, we could either use the raw pull request title, or maybe do something like:

[Pull][gaia-email-libs-and-more] jrburke:bug1098289-email-request-sync to mozilla-b2g:master

(This could potentially be too long of a title)
(Assignee)

Comment 1

4 years ago
Created attachment 8562531 [details]
[Pull][gaia-email-libs-and-more] KevinGrandon:bug1131906-some-branch-name to mozilla-b2g:master

Test attachment to see if the title is too long.
(Assignee)

Comment 2

4 years ago
(In reply to Kevin Grandon :kgrandon from comment #1)
> Test attachment to see if the title is too long.

This is actually not terrible on my display, but it is a bit long.

James, Andrew - I'm mainly filing this bug to address the GELAM workflow so we can more easily differentiate between gaia and gelam pull requests. Just wanted to get feedback from you on the proposed changes as you guys have the most experience with the GELAM workflow. We can also completely change the formatting if you have a better idea. Thanks!
Flags: needinfo?(jrburke)
Flags: needinfo?(bugmail)
I like the inclusion of the repo name. I wonder if the [Pull] part is necessary, maybe that can be implied by the rest of the name that mention branches and repo targets.

Really just bikeshedding here, as I do not know if the square brackets are semantically meaningful for something, but this works for me:

gaia-email-libs-and-more: KevinGrandon:bug1131906-some-branch-name > mozilla-b2g:master

But really, fine with whatever you see fit.
Flags: needinfo?(jrburke)
(Assignee)

Comment 4

4 years ago
(In reply to James Burke [:jrburke] from comment #3)
> I like the inclusion of the repo name. I wonder if the [Pull] part is
> necessary, maybe that can be implied by the rest of the name that mention
> branches and repo targets.

This is a good point. Normally you would always see the mime type next to the attachment (text/x-github-pull-request) which makes this pretty clear. Let's axe the [Pull]/[PullReq] tag as it seems unnecessary.


> Really just bikeshedding here, as I do not know if the square brackets are
> semantically meaningful for something, but this works for me:
> 
> gaia-email-libs-and-more: KevinGrandon:bug1131906-some-branch-name >
> mozilla-b2g:master

Sounds good. I think we should plan on going with something like this. I'm hesitant to add yet another colon as we separate the user/branch with that already, but I'll play with brackets or a dash to see what feels nice. Thanks for the feedback!
Created attachment 8562545 [details] [review]
[PullReq] KevinGrandon:bug_1131906_attachment_naming to mozilla:master
(Assignee)

Updated

4 years ago
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Thanks for taking the initiative on filing and fixing this!  I actually started to try and file a bug the other day, but when I typed in "autoland" I got multiple ambiguous things and gave up.  (Which may be for the best since none of them were this component.  It might be good to file a bug to get the component info expanded from "Github bot automation tools." so this component can be found with the autocomplete-ish magic for bug filing.)

I like what you have in the pull request, specifically:
[gaia] KevinGrandon:my_whatever_branch > mozilla-b2g:master

I'm with you that too many colons could be co(lo)nfusing! :)
Flags: needinfo?(bugmail)
(Assignee)

Comment 7

4 years ago
Yes, we definitely need to fix the component name here. I just sort of inherited this previously used component for autolander, but will go ahead and do a quick update to at least update the component description.
(Assignee)

Comment 8

4 years ago
Tests seem to be passing and this is pretty simple, so landing: https://github.com/mozilla/autolander/commit/ca7ef10b2de3790dec196a2b29fcfa2500f02b17
(Assignee)

Comment 9

4 years ago
Deployed v66@ca7ef10.
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.