Closed Bug 1131940 Opened 5 years ago Closed 5 years ago

getMigratedData in ResetProfile.jsm is unused and can be deleted

Categories

(Toolkit :: General, defect, trivial)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox38 --- fixed

People

(Reporter: MattN, Assigned: ankit.goyal90, Mentored)

References

Details

(Whiteboard: [lang=js] [good first bug])

Attachments

(1 file, 1 obsolete file)

Bug 1063702 deleted the caller but didn't delete the leftover method.
Product: Firefox → Toolkit
Comment on attachment 8563271 [details] [diff] [review]
Bug 1131940 - getMigratedData in ResetProfile.jsm is unused and can be deleted. r=MattN

Review of attachment 8563271 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! In the future you can add a commit message when attaching for review so we can simply use checkin-needed when you get r+. A good commit message desribes what the commit is doing when the bug summary describes a problem.
Attachment #8563271 - Flags: review?(MattN+bmo) → review+
This is dead code according to MXR so it doesn't seem like a good use of a try run.
Attachment #8563271 - Attachment is obsolete: true
Attachment #8564295 - Flags: review+
Assignee: nobody → ankit.goyal90
Status: NEW → ASSIGNED
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/f0048ba13213
Keywords: checkin-needed
Whiteboard: [lang=js] [good first bug] → [lang=js] [good first bug][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/f0048ba13213
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [lang=js] [good first bug][fixed-in-fx-team] → [lang=js] [good first bug]
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.