Closed
Bug 1131940
Opened 9 years ago
Closed 9 years ago
getMigratedData in ResetProfile.jsm is unused and can be deleted
Categories
(Toolkit :: General, defect)
Toolkit
General
Tracking
()
RESOLVED
FIXED
mozilla38
| Tracking | Status | |
|---|---|---|
| firefox38 | --- | fixed |
People
(Reporter: MattN, Assigned: ankit.goyal90, Mentored)
References
Details
(Whiteboard: [lang=js] [good first bug])
Attachments
(1 file, 1 obsolete file)
|
1.55 KB,
patch
|
MattN
:
review+
|
Details | Diff | Splinter Review |
Bug 1063702 deleted the caller but didn't delete the leftover method.
|
Reporter | |
Updated•9 years ago
|
Product: Firefox → Toolkit
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8563271 -
Flags: review?(MattN+bmo)
|
|
Reporter | |
Comment 2•9 years ago
|
||
Comment on attachment 8563271 [details] [diff] [review] Bug 1131940 - getMigratedData in ResetProfile.jsm is unused and can be deleted. r=MattN Review of attachment 8563271 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! In the future you can add a commit message when attaching for review so we can simply use checkin-needed when you get r+. A good commit message desribes what the commit is doing when the bug summary describes a problem.
Attachment #8563271 -
Flags: review?(MattN+bmo) → review+
|
|
Reporter | |
Comment 3•9 years ago
|
||
This is dead code according to MXR so it doesn't seem like a good use of a try run.
Attachment #8563271 -
Attachment is obsolete: true
Attachment #8564295 -
Flags: review+
|
|
Reporter | |
Updated•9 years ago
|
|
||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/f0048ba13213
Keywords: checkin-needed
Whiteboard: [lang=js] [good first bug] → [lang=js] [good first bug][fixed-in-fx-team]
|
|
||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f0048ba13213
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox38:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [lang=js] [good first bug][fixed-in-fx-team] → [lang=js] [good first bug]
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•