1132006 - "Restore all crashed tabs" doesn't restore all tabs in all windows

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[(not currently active) Ted Mielczarek]

I had a content process crash, clicked "restore all crashed tabs", and it happily restored all the tabs *in the current window*, leaving a bunch of tabs displaying about:tabcrashed in the other window I had open. Clicking the same button in one of those restored those tabs properly.

Comment 1

[Wayne Mery (:wsmwk)]

Same here. I had been futzing with screen configuration and resolution maybe 10 minutes before the crash.

And first time in an long time that I've been running e10s. Also in dual monitor. Don't know if that's related.

Comment 2

[(not currently active) Ted Mielczarek]

This is getting pretty dogfood-y for me. I don't crash all that often, but crashes come in spurts on Nightly, so I'll wind up having to restore crashed tabs a bunch of times in a row, and I have to do it for every window.

Comment 3

[Wayne Mery (:wsmwk)]

This hadn't happened to me for about a month.  But I've now had 3-4 times on the past week.  ("Mirror, Mirror" Star Trek episode comes to mind.)

Comment 4

[Dave Townsend [:mossop]]

Strange, the restore all tabs code is meant to be iterating all the windows: http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#1182

Comment 5

[Mike Conley (:mconley) (:⚙️)]

billm - mind if I take this one off your hands?

Comment 6

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

By all means!

Comment 7

[Mike Conley (:mconley) (:⚙️)]

I can easily reproduce this.

STR:

1) Install TabCrasher[1] or CrashMe[2] to get tab crashing powers
2) Open two windows, and add tabs in each browsed to some web content
3) In one of the windows, crash the tabs (both add-ons add buttons to crash the content process)
4) In one of the crashed windows, choose "Restore All Crashed Tabs"

ER:

All crashed tabs across all windows should be restored

AR:

Only the crashed tabs in the window where the user clicked "Restore All Crashed Tabs" are restored.


[1]: https://addons.mozilla.org/en-US/firefox/addon/tab-crasher/
[2]: http://people.mozilla.org/~tmielczarek/crashme/

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Attachment: MozReview Request: Bug 1132006 - Properly iterate all browser windows when restoring crashed tabs. r=?

Bug 1132006 - Properly iterate all browser windows when restoring crashed tabs. r=?

Comment 9

[Dave Townsend [:mossop]]

Comment on attachment 8616089 [details]
MozReview Request: Bug 1132006 - Properly iterate all browser windows when restoring crashed tabs. r=?

https://reviewboard.mozilla.org/r/10427/#review9131

*facepalm*

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/8598c111fcf3

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8598c111fcf3

Comment 12

[(not currently active) Ted Mielczarek]

Thanks for fixing this! Were the tests we had not comprehensive enough to catch this?

Comment 13

[Mike Conley (:mconley) (:⚙️)]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #12)
> Thanks for fixing this! Were the tests we had not comprehensive enough to
> catch this?

I'm afraid not. :(

Comment 14

[Mike Conley (:mconley) (:⚙️)]

Filed bug 1172539 about adding new tests.

Comment 15

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bugnotes

http://people.mozilla.org/~mconley2/bugnotes/bug-1132006.html

Comment 16

[Saheda Reza [:Antora]]

Reproduced this bug on Firefox nightly Version 	38.0a1

It's fixed and verified on Latest nightly

Build ID 	20150901030226
User Agent 	Mozilla/5.0 (Windows NT 6.3; rv:43.0) Gecko/20100101 Firefox/43.0

Tested OS-- windows 32bit

Comment 17

[Saheda Reza [:Antora]]

One mistake ..... It should be

Tested OS --- windows 8.1 32bit