1132010 - mozilla contact emails don't work if they aren't registered users

Status: VERIFIED FIXED

(Marketplace Graveyard :: Developer Pages, defect, P1)

Description

[Andrew Williamson [:eviljeff]]

(noticed during some testing recently)

The Mozilla contact field in the apps edit page is a free text field for email addresses.  However, it appears that any email address entered which doesn't correspond to a registered user doesn't receive any email.  I'm guessing this happened post the commbadge switch on in Q3/Q4.

Two possible fixes:
A) revert to previous behaviour and email every email address in the field
B) validate the field to prevent unregistered email addresses being entered; (and in the model change the attribute from text to a foreign key to many User)

Comment 1

[Andrew Williamson [:eviljeff]]

NI for the two affected parties (biz dev and dev rel) -
workaround is either registering on Marketplace with those addresses or I ask IT to run some sql on the database to change the mailing list you use (apps-bd@ ; techeven@) to a registered user.

Comment 2

[Dan Callahan [:callahad]]

I just joined DevRel in the past few months, so I don't have a ton of context for our work on FxOS apps / marketplace... could you explain what sort of emails get sent and how often? That will guide our decision on keeping things on the main list (techevan@), or setting up a separate registered user.

Comment 3

[Andrew Williamson [:eviljeff]]

(In reply to Dan Callahan [:callahad] from comment #2)
> I just joined DevRel in the past few months, so I don't have a ton of
> context for our work on FxOS apps / marketplace... could you explain what
> sort of emails get sent and how often? That will guide our decision on
> keeping things on the main list (techevan@), or setting up a separate
> registered user.

You get copied on all correspondence between the developer, reviewer, and Marketplace itself.  So for some apps it will be 1 email on approval; and others there may be a few back and forth. Packaged apps will result in this kind of email correspondence for each version.  The most extreme will probably be a hosted app that has an unreliable server and goes up and down every few days - I've seen apps with 50+ of these kind of messages.

Comment 4

[Desigan Chinniah [:cyberdees] [:dees] [London - GMT]]

In general within the field, BD folks enter themselves rather than an alias like apps-bd@

However we should likely cover the alias angle too for maybe those that don't have specific owners.

Andrew - Have you asked IT to have the mailing alias added as a registered user?

Comment 5

[Desigan Chinniah [:cyberdees] [:dees] [London - GMT]]

Also can you maybe please cross-reference these emails and confirm which ARE NOT registered users:

Didem Ersoz <[e-mail]>, Mano Balasubramaniam <[e-mail]>, Oliver Duric <[e-mail]>, Silvio Chiba <[e-mail]>, Desigan Chinniah <[e-mail]>, APPS BD

Harald Kirschner <[e-mail]>, Nick Desaulniers <[e-mail]>, Louis Stowasser <[e-mail]>, Bill Walker <[e-mail]>, APPS PARTNER ENGINEERING

Comment 6

[Andrew Williamson [:eviljeff]]

I wouldn't have thought IT can add the apps-bd@ list - someone with list access needs to create a FirefoxAccount with that email, and confirm its valid with the link in the confirmation email.  Once that's done its just a matter of logging into Marketplace once with it.

Re: the emails for your team members - they all appear to be registered users.

Comment 7

[Desigan Chinniah [:cyberdees] [:dees] [London - GMT]]

(In reply to Andrew Williamson [:eviljeff] from comment #6)
> I wouldn't have thought IT can add the apps-bd@ list - someone with list
> access needs to create a FirefoxAccount with that email, and confirm its
> valid with the link in the confirmation email.  Once that's done its just a
> matter of logging into Marketplace once with it.

This address should now be verified. Can you confirm?


> 
> Re: the emails for your team members - they all appear to be registered
> users.

Great.

Comment 8

[Andrew Williamson [:eviljeff]]

(In reply to Desigan Chinniah [:cyberdees] [:dees] [London - GMT] from comment #7)
> (In reply to Andrew Williamson [:eviljeff] from comment #6)
> > I wouldn't have thought IT can add the apps-bd@ list - someone with list
> > access needs to create a FirefoxAccount with that email, and confirm its
> > valid with the link in the confirmation email.  Once that's done its just a
> > matter of logging into Marketplace once with it.
> 
> This address should now be verified. Can you confirm?

Confirmed.  (In theory) that should be fixed for you now, though if you don't receive any Marketplace emails to that address in the next few days something else is afoot.

Comment 9

[Kevin Ngo [:ngoke]]

https://github.com/mozilla/zamboni/pull/2951

Comment 10

[Kevin Ngo [:ngoke]]

STR:

1. In the Developer Hub, set the Mozilla contact of an app to an email. The email must not be registered as a user.
2. Do a reviewer action on the app (e.g, approve, reject, reviewer comment).

Expected:

The Mozilla contact should get an email. However, the Mozilla contact will not be able to Reply-To the email unless they create an account.

Actual:

The Mozilla contact does not get any email.

Comment 11

[Madalin Cotetiu]

When trying to approving an app to which I have added a mozilla contact the approving fails with an "Oops.." error. I think this is related to this fix because approving other apps (with no mozilla contact added) worked fine.
Please view this screencast: http://screencast.com/t/TY1sKNsfv
Reopening bug.

Comment 12

[Andrew Williamson [:eviljeff]]

http://sentry.dmz.phx1.mozilla.com/marketplace-stage/marketplace-stage/group/25645/
'TemplateNotFound: comm/emails/{'nonuser_mozilla_contact': True}.html'

Comment 13

[Andrew Williamson [:eviljeff]]

https://github.com/mozilla/zamboni/pull/2969 to fix

Comment 14

[Kevin Ngo [:ngoke]]

Thanks Andrew for the quick fix.

Comment 15

[Madalin Cotetiu]

Approving works correctly now, also the email is sent to the mozilla contact: http://screencast.com/t/BxLNNzSB
Closing bug.