Closed Bug 1132021 Opened 5 years ago Closed 5 years ago

Use USER_LIMITED access token level for the Windows NPAPI process sandboxing policy

Categories

(Core :: Security: Process Sandboxing, defect)

All
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox38 --- fixed

People

(Reporter: bobowen, Assigned: bobowen)

References

Details

Attachments

(1 file)

As suggested by bbondy in Bug 1126402 Comment 5, this is an attempt to get a workable NPAPI sandbox (primarily for flash) using the USER_LIMITED access level token.
This patch adds a "level" 3 for the NPAPI, setting the access token to USER_LIMITED.
This removes the user's own token from the process's access token,

It adds rules to give read/write access to the two flash AppData directories and the Temp directory.

It also adds read access to the User's home directory for file upload.

Trying to improve any of the sandbox policy further seems to break at least some part of video/audio playback.
Attachment #8562844 - Flags: review?(netzen)
Attachment #8562844 - Flags: review?(benjamin)
Comment on attachment 8562844 [details] [diff] [review]
Add a new sandbox level for Windows NPAPI to use USER_LIMITED access token level.

I'm skeptical that we could ever use this in a default environment, but I think it's worth having the options available!
Attachment #8562844 - Flags: review?(benjamin) → review+
(In reply to Benjamin Smedberg  [:bsmedberg] from comment #2)
> Comment on attachment 8562844 [details] [diff] [review]
> Add a new sandbox level for Windows NPAPI to use USER_LIMITED access token
> level.
> 
> I'm skeptical that we could ever use this in a default environment, but I
> think it's worth having the options available!

Thanks.
Yeah, this would need some thorough testing and at the very least it may restrict from where files can be uploaded.
At least it gives different things to try if we get some sort of test suite.

Try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8eb5933b6550
Attachment #8562844 - Flags: review?(netzen) → review+
Try push in comment 3, thanks.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/44d8619d58b8
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.