Closed Bug 1132109 Opened 5 years ago Closed 5 years ago

TSan: data race netwerk/cache2/CacheEntry.cpp:1018 SetExpirationTime

Categories

(Core :: Networking: Cache, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox38 --- fixed

People

(Reporter: froydnj, Assigned: mayhemer)

References

(Blocks 1 open bug)

Details

(Whiteboard: [tsan])

Attachments

(2 files, 1 obsolete file)

Attached file netwerk-cache-race.txt
[cribbing from decoder's script, hopefully he won't mind]

The attached logfile shows a thread/data race detected by TSan (ThreadSanitizer).

Typically, races reported by TSan are not false positives, but it is possible that the race is benign. Even in this case though, we should try to come up with a fix unless this would cause unacceptable performance issues. Also note that seemingly benign races can possibly be harmful (also depending on the compiler and the architecture) [1].

If the bug cannot be fixed, then this bug should be used to either make a compile-time annotation for blacklisting or add an entry to the runtime blacklist.

I don't know why TSan thinks this race is in operator->; it's pretty clearly in SetExpirationTime.  Maybe the debug information is poor.

[1] http://software.intel.com/en-us/blogs/2013/01/06/benign-data-races-what-could-possibly-go-wrong
Atomic<relaxed>

->me
Assignee: nobody → honzab.moz
Status: NEW → ASSIGNED
Attached patch v1 (obsolete) — Splinter Review
Attachment #8562948 - Flags: review?(michal.novotny)
Attachment #8562948 - Flags: review?(michal.novotny) → review+
Attached patch v1 (ci msg)Splinter Review
Attachment #8562948 - Attachment is obsolete: true
Attachment #8564181 - Flags: review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/db8257416bff
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.