1132138 - File size not being displayed on app details page

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P3)

Description

[Kevin Ngo [:ngoke]]

Some backend issue.

STR:

1. Go to app detail page.
2. Scroll to bottom More Info section.

Expected:

Can see file size.

Comment 1

[Kevin Ngo [:ngoke]]

Note this is a backend bug. It should be deserializing the file size but it is coming back as null.

Also, need to format the file size as MBs.

Comment 2

[Kevin Ngo [:ngoke]]

...or KBs

Comment 3

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/zamboni/commit/f9773a0bee7cc770e79fa698bd2a07c481509005

QA note: please test with both a packaged and an hosted app.

Comment 4

[Madalin Cotetiu]

Verified in FF38(Win7) in marketplace-dev.allizom.org
The size is displayed in the More Information section but it appears is not accurate for hosted apps.
In example I have used this app: https://marketplace-dev.allizom.org/app/kcals?src=search which has the displayed size of 2.3 KB but the actual size of the installed app is greater
Please view this screencast: http://screencast.com/t/f9mT9pLpkiZQ

Comment 5

[Mathieu Pillard [:mat]]

It can never be accurate for hosted apps, as the only information we have is the size of the manifest file. I'm tempted to say we should hide this information for hosted apps. :ddurst, what do you think ?

Comment 6

[David Durst [:ddurst]]

If we don't know it, let's not show it.

Comment 7

[Kevin Ngo [:ngoke]]

It is sort of accurate as the manifest file is the space needed to actually install the app.

Comment 8

[Mathieu Pillard [:mat]]

It's the minimum needed, but if the app uses offline cache for instance, it's going to be wrong.

Comment 9

[Kevin Ngo [:ngoke]]

Packaged apps can use offline cache, although most likely not as heavily, wouldn't that mean that "may" be wrong as well?

Comment 10

[Mathieu Pillard [:mat]]

mmm, true. Now I'm confused and don't know what to think anymore :)

Comment 11

[Kevin Ngo [:ngoke]]

Also helps that whatever apps cache is not permanent. We can just take file size to mean however much it takes to install and however much space the app permanently takes. Many hosted apps may not do offline caching either.

Comment 12

[David Durst [:ddurst]]

The expectation is that you can install and run it if you have sufficient space. So, I'd still say we show it for packaged apps and not hosted ones, based on comment 9. They're both wrong, so you're stuck guessing on what "else" they might load.

Sounds like we're more likely to be wrong/grossly inaccurate on hosted than packaged because the hosted size is only of the manifest file, and not other assets loaded by the app; and we're more likely to be right/closer on packaged apps because they're less likely to load more additional stuff beyond what's in the package.

If someone has strong feelings about it, though, we should just remove it.

Comment 13

[Mathieu Pillard [:mat]]

Spent some time thinking about it. Apologies for the super-long debate for such a small feature.

I think it's useful information (especially when it's big) so we should keep it. We don't guarantee that the app is going to download more, so it's not a representation of the size on disk, but rather a representation of the initial download.

The only real concerns are:

  - Appcache preloading that the platform does when installing an app. From the comments in
    https://dxr.mozilla.org/mozilla-central/source/dom/apps/Webapps.jsm it *looks* like it's
    only done for hosted apps ("This is a hosted app, let's check if it has an appcache download it.").

  - Downloading of icons. This is only a problem for hosted apps, but depends on the platform, since different devices can use different icons.

Trying to determine the correct download size for either of these things is a lot of work for such a feature IMHO, and even if we downloaded the icons, appcache and assets it links to nightly when we update hosted manifest, we'd still don't know if that would accurately reflect the current size when the user initiates a download.

Therefore, I vote to keep it only for packaged apps (where we know it's going to be true for the initial download, and can really help the user making a decision) and remove it from hosted apps. The additional PR I submitted on Friday does that : https://github.com/mozilla/fireplace/pull/1039

Comment 14

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/fireplace/commit/2c68e53c82b41855eaf3515938d51a33972c89e2

File size will be shown for packaged apps, not hosted apps. Note that it won't necessarily match the size of the app on disk once downloaded (that can vary), but it will match the size of the initial download at install time.

Comment 15

[Madalin Cotetiu]

Verified as fixed in FF38(Win7) in marketplace-dev.allizom.org
File size is no longer displayed for hosted apps. For packaged apps is still displayed and is pretty accurate. I have tried using many apps and I observed that there is a few KB differences, but after reading the discussion above, I think that difference is acceptable.
Some examples:  http://screencast.com/t/mPYZ6P9Q  http://screencast.com/t/AGnACflPndz  http://screencast.com/t/KJDtCivFk2

So in my opinion that looks pretty accurate, the maxim differences observed is a few KB. What do you thin mat?

Comment 16

[Mathieu Pillard [:mat]]

It's fine, a few kb difference is expected depending on how your OS display the size etc.

Comment 17

[Madalin Cotetiu]

Closing bug.