Closed Bug 1132149 Opened 5 years ago Closed 5 years ago

Root the proto argument to NewArray and friends

Categories

(Core :: JavaScript: GC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox38 --- fixed

People

(Reporter: terrence, Assigned: terrence)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Not really anything particularly interesting here.
Attachment #8562931 - Flags: review?(sphink)
Blocks: 1132286
Comment on attachment 8562931 [details] [diff] [review]
6.1_handlify_proto_for_newarray-v0.diff

Review of attachment 8562931 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsobj.cpp
@@ -1963,5 @@
>          if (!xdr->codeUint32(&length))
>              return false;
>  
>          if (mode == XDR_DECODE)
> -            obj.set(NewDenseUnallocatedArray(cx, length, NULL, js::MaybeSingletonObject));

Wow, we still had a NULL!
Attachment #8562931 - Flags: review?(sphink) → review+
https://hg.mozilla.org/mozilla-central/rev/ded390f05c90
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.