New dev deployment of Commonplace project: marketplace-style-guide

RESOLVED FIXED

Status

Cloud Services
Operations: Marketplace
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: chuck, Assigned: jason)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

3 years ago
Repository: https://github.com/mozilla/marketplace-style-guide
Preferred URL: styleguide.marketplace-dev.allizom.org

Automatic dev deployments on commits to that repository would be the best.
(Assignee)

Updated

3 years ago
Assignee: nobody → jthomas
(Assignee)

Comment 1

3 years ago
'make build' is failing, specifically on the following:

[18:04:02] Starting 'templates_build_sync'...
Stylus compile error: ParseError
/home/jason/src/jasonthomas/marketplace-style-guide/bower_components/jeet/stylus/jeet/_settings.styl:6
    2|  * Grid settings.
    3|  * All values are defaults and can therefore be easily overidden.
    4|  */
    5|
 >  6| jeet = {
    7|   gutter: 3,
    8|   parent-first: false,
    9|   layout-direction: LTR,

invalid right-hand side operand in assignment, got "{"

This is related to a older version of stylus being installed as a dependency https://github.com/mozilla/marketplace-gulp/blob/master/package.json#L43. We need at least 0.39.x here since that is when hashes were added to stylus. Can we bump the version?
(Reporter)

Comment 2

3 years ago
These two commits should clean it up:

https://github.com/mozilla/marketplace-style-guide/commit/a1b2f116a25d73793266fd9e4e675f7bb74c6d29
https://github.com/mozilla/marketplace-style-guide/commit/b7fd300ada2da3f1b0bcdcd315209481c31aeb49

It was able to build successfully locally with them. If for some reason it's still failing, try running this from the root of the repo:

    ./node_modules/marketplace-gulp/node_modules/stylus/bin/stylus --version

It should respond with 0.50.0.
(Assignee)

Comment 3

3 years ago
I've set this up at https://marketplace-styleguide-dev.allizom.org/ since we have a wildcard cert for allizom.org.

github webhook setup for -dev deployment via jenkins.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Updated

3 years ago
Blocks: 1137349
You need to log in before you can comment on or make changes to this bug.