Closed
Bug 1132153
Opened 9 years ago
Closed 9 years ago
"using namespace base" considered harmful
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla38
Tracking | Status | |
---|---|---|
firefox38 | --- | fixed |
People
(Reporter: botond, Assigned: botond)
References
Details
Attachments
(1 file)
10.83 KB,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
"base" is a namespace used by code in ipc/chromium/src/base. Several files that make use of things in this namespace do "using namespace base" [1]. This sometimes causes annoying name clashes. Due to unified compilation, removing a single use of "using namespace base" often isn't enough to fix a name clash. I propose we get rid of them all. https://dxr.mozilla.org/mozilla-central/search?q=%22using%20namespace%20base%22&=mozilla-central&redirect=true
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → botond
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8564432 -
Flags: review?(dholbert)
Assignee | ||
Comment 2•9 years ago
|
||
green try |
Successful build-only Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cc45ab0eeb27
Comment 3•9 years ago
|
||
Comment on attachment 8564432 [details] [diff] [review] Replace 'using namespace base' with specific using-declarations Looks good to me. Thanks!
Attachment #8564432 -
Flags: review?(dholbert) → review+
Updated•9 years ago
|
OS: Linux → All
Hardware: x86_64 → All
Assignee | ||
Comment 4•9 years ago
|
||
landing |
https://hg.mozilla.org/integration/mozilla-inbound/rev/22cb52f4cab4
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/22cb52f4cab4
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox38:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•