Closed Bug 1132153 Opened 9 years ago Closed 9 years ago

"using namespace base" considered harmful

Categories

(Core :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox38 --- fixed

People

(Reporter: botond, Assigned: botond)

References

Details

Attachments

(1 file)

"base" is a namespace used by code in ipc/chromium/src/base. 

Several files that make use of things in this namespace do "using namespace base" [1]. This sometimes causes annoying name clashes.

Due to unified compilation, removing a single use of "using namespace base" often isn't enough to fix a name clash. I propose we get rid of them all.

https://dxr.mozilla.org/mozilla-central/search?q=%22using%20namespace%20base%22&=mozilla-central&redirect=true
Assignee: nobody → botond
Successful build-only Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cc45ab0eeb27
Comment on attachment 8564432 [details] [diff] [review]
Replace 'using namespace base' with specific using-declarations

Looks good to me. Thanks!
Attachment #8564432 - Flags: review?(dholbert) → review+
OS: Linux → All
Hardware: x86_64 → All
https://hg.mozilla.org/mozilla-central/rev/22cb52f4cab4
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Depends on: 1135591
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: