bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

move system/stl header wrapping from config/Makefile.in into moz.build

NEW
Unassigned

Status

Firefox Build System
General
4 years ago
5 months ago

People

(Reporter: froydnj, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

4 years ago
Our makefile rules for wrapping system/stl headers is rather large:

http://mxr.mozilla.org/mozilla-central/source/config/Makefile.in#63

We should just have something like:

WRAPPED_SYSTEM_INCLUDES += ['system-headers']
WRAPPED_STL_INCLUDES += ['stl-headers']

and let moz.build generate the appropriate rules, or do the generating itself, or whatever.

Bonus:

- we don't have to use make-system-wrappers.pl from NSPR anymore
- we don't have to generate the headers in a temporary directory; we can generate them directly into dist/include/
I'd say we don't need this in moz.build at all, we could just call a python script to generate it from configure. The only thing that might be weird is generating the rules to rebuild if the deps change, but I don't think it's that complicated.
(Reporter)

Comment 2

4 years ago
I didn't know if we had to care about PGO builds still blowing away dist/.  If we don't, then just generating it at configure time would be sufficient and better.

Updated

5 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.