Closed Bug 1132179 Opened 9 years ago Closed 9 years ago

[raptor] Allow custom configurations of devices for performance testing

Categories

(Firefox OS Graveyard :: Gaia::PerformanceTest, defect)

ARM
Gonk (Firefox OS)
defect
Not set
major

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ikumar, Assigned: Eli)

References

Details

(Keywords: perf, Whiteboard: [caf priority: p2][CR 795090])

Attachments

(3 files)

There exist devices that are not available to everyone for various reasons - not enough to share, can’t share, don't want to share - so a centralized device repository doesn't work.
blocking-b2g: --- → 2.2?
Keywords: perf
Assignee: nobody → eperelman
I see the solution to this being either an environment variable flag pointing to a custom configuration file, or Raptor determines a conventional location for a custom configuration file to exist.
Whiteboard: [CR 795090]
Whiteboard: [CR 795090] → [caf priority: p2][CR 795090]
(In reply to :Eli Perelman from comment #1)
> I see the solution to this being either an environment variable flag
> pointing to a custom configuration file, or Raptor determines a conventional
> location for a custom configuration file to exist.

Passing in as a flag sounds like the most convenient option.  "conventional location" sounds like modification/population of files in the src area which we'd like to continue to avoid.
Flagging Ravi on this to provide context and blocking rationale that are missing from the original description and nomination.
Flags: needinfo?(rdandu)
[Blocking Requested - why for this release]:
This should not block 2.2. It is not a device side bug, this is on a new tool which tracks performance.
Flags: needinfo?(rdandu)
Ravi,

Per my triage with CAF today, a fix for this issue is still needed for them to use Raptor that implies that this issue needs to be 2.2+ blocking-b2g or feature-b2g. Is there a reason why neither flag was set or 2.2? cleared?

Thanks,
Mike
Flags: needinfo?(rdandu)
Clarified with :eli on IRC that Raptor delivery is planned for end of Q1 which aligns with the current 2.2 FC date of April 6th at https://wiki.mozilla.org/B2G/Roadmap

This means Raptor is scheduled to be delivered for 2.2 FC and not 2.2 FL.
Flags: needinfo?(rdandu)
Comment on attachment 8571381 [details] [review]
Link to Github pull-request: https://github.com/eliperelman/node-mozdevice/pull/9

LGTM and works great. Removed the emulator-kk from the node-mozdevice/config.json, added it to a separate config.json, then provided that second config as MOZDEVICE_CONFIG and the raptor emulator launch test ran fine.
Attachment #8571381 - Flags: review?(rwood) → review+
Comment on attachment 8572026 [details] [review]
[gaia-node-modules] eliperelman:bug-1132179 > mozilla-b2g:master

Carrying over r+.
Attachment #8572026 - Flags: review+
Comment on attachment 8572027 [details] [review]
[gaia] eliperelman:bug-1132179 > mozilla-b2g:master

Carrying over r+.
Attachment #8572027 - Flags: review+
blocking-b2g: 2.2? → ---
No longer blocks: CAF-v3.0-FL-metabug
No longer blocks: PerformanceProgram
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: