Closed Bug 1132184 Opened 5 years ago Closed 5 years ago

Remove PostCreate and PostTransplant hooks

Categories

(Core :: XPConnect, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox38 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

The only PostTransplant hooks we have in the tree are nsDOMClassInfo::PostTransplant which does:

   MOZ_CRASH("nsDOMClassInfo::PostTransplant Don't call me!");

and the one from xpc_map_end.h which does:

   NS_ERROR("never called"); return NS_ERROR_NOT_IMPLEMENTED;

The only PostCreate hooks we have are nsDOMClassInfo::PostCreate, which does:

   NS_WARNING("nsDOMClassInfo::PostCreate Don't call me!");
   return NS_ERROR_UNEXPECTED;

and the one from xpc_map_end.h which does:

   NS_ERROR("never called"); return NS_ERROR_NOT_IMPLEMENTED;

So I claim we can just nix the lot.

After bug 1131801, PostTransplant isn't even called.
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Blocks: 1132187
Attachment #8562996 - Flags: review?(peterv) → review+
https://hg.mozilla.org/mozilla-central/rev/3bdb77f15f2e
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.