Closed Bug 1132192 Opened 9 years ago Closed 9 years ago

Enable org.mozilla.searches.engines in FHR

Categories

(Firefox Health Report Graveyard :: Client: Desktop, defect)

Product:
Firefox Health Report Graveyard
Component:
Client: Desktop
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox37 fixed, firefox38 fixed, firefox39 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 39
Tracking Flags:
Tracking Status
firefox37 --- fixed
firefox38 --- fixed
firefox39 --- fixed

People

(Reporter: jjensen, Assigned: benjamin)

Details

Attachments

(1 file)

1132192
2.86 KB, patch
gps
: review+
lsblakk
: approval-mozilla-aurora+
lsblakk
: approval-mozilla-beta+
Details | Diff | Splinter Review 
This exists in Telemetry. Let's enable it in FHR.
Assignee: nobody → benjamin
Target Milestone: --- → Firefox 38
Updating based on on an exchange with Benjamin.
Attached patch 1132192 — — Splinter Review 

        Attachment #8573421 -
        Flags: review?(gps)

    
    

    
  
Comment on attachment 8573421 [details] [diff] [review]
1132192

Review of attachment 8573421 [details] [diff] [review]:
-----------------------------------------------------------------

This is 95% policy 5% code and you control the policy. So I'll happily rubber stamp the minor code change.

        Attachment #8573421 -
        Flags: review?(gps) → review+

    
    

    
  
https://hg.mozilla.org/integration/mozilla-inbound/rev/cbfb5e4c944a
Target Milestone: Firefox 38 → Firefox 39

    
    

    
  
Comment on attachment 8573421 [details] [diff] [review]
1132192

Approval Request Comment
[Feature/regressing bug #]: Useful data not collected for release users
[User impact if declined]: We won't be able to measure the effects of search hijacking effectively without this change.
[Describe test coverage new/current, TreeHerder]:
[Risks and why]: low risk: this is already measured for telemetry users and the only functional change is removing a check that measures this for all users.
[String/UUID change made/needed]: none

        Attachment #8573421 -
        Flags: approval-mozilla-beta?

        Attachment #8573421 -
        Flags: approval-mozilla-aurora?

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/cbfb5e4c944a
Status: NEW → RESOLVED
Closed: 9 years ago

          status-firefox39:
          --- → fixed
Resolution: --- → FIXED

        Attachment #8573421 -
        Flags: approval-mozilla-beta?

        Attachment #8573421 -
        Flags: approval-mozilla-beta+

        Attachment #8573421 -
        Flags: approval-mozilla-aurora?

        Attachment #8573421 -
        Flags: approval-mozilla-aurora+

    
  
Product: Firefox Health Report → Firefox Health Report Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: