Closed
Bug 1132218
Opened 10 years ago
Closed 10 years ago
Update comm-central for PLDHashTable changes in bug 1131901
Categories
(MailNews Core :: Backend, defect)
MailNews Core
Backend
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 40.0
People
(Reporter: n.nethercote, Assigned: philip.chee)
References
Details
Attachments
(1 file)
|
3.92 KB,
patch
|
rkent
:
review+
|
Details | Diff | Splinter Review |
Bug 1131901 make the existing PL_DHashTableAdd() function infallible, and added a fallible variant (which takes a fallible_t arg). The parts of the patch from bug 1129692 dealing with PL_DHashTableAdd() will need to be reused here.
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → philip.chee
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•10 years ago
|
||
> - PLDHashEntryHdr *entry = PL_DHashTableAdd(m_cachedHeaders, (void *)(uintptr_t) key);
> + PLDHashEntryHdr *entry = PL_DHashTableAdd(m_cachedHeaders, (void *)(uintptr_t) key, mozilla::fallible);
> if (!entry)
> return NS_ERROR_OUT_OF_MEMORY; // XXX out of memory
Maybe these should be infallible but someone who knows this code better will have to decide.
Attachment #8589044 -
Flags: review?(rkent)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8589044 [details] [diff] [review]
Patch v1.0 use mozilla::fallible
fallible is fine, that is the conservative thing to do for now.
Attachment #8589044 -
Flags: review?(rkent) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/05a5f777433d
Severity: critical → normal
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 40.0
You need to log in
before you can comment on or make changes to this bug.
Description
•