1132238 - [RTL][Calendar] Accounts are incorrectly truncated.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect, P2)

Description

[Yeojin Chung [:YeojinC]]

Attachment: Accounts.png

Description:
On Calendar Settings screen, the added accounts are truncated incorrectly. 

Repro Steps:
1) Update a Flame device to BuildID: 
2) Set the device language in Arabic under Settings > Language.
3) Select the drawer icon, and the settings icon.
4) Select "Add account", and add a valid calendar account.
5) Return to the Calendar Settings screen, and observed the added account.

Actual:
Truncation occurs at the beginning of the section, such as "Google" or "Yahoo!".
  
Expected:
Truncation occurs at the end of the section, so the email address is truncated.
 

Device: Flame Master (319mb, full flash)
Build ID: 20150211010216
Gaia: 8c7865486a1b11076b849bbf8f7fccbaffbfafe7
Gecko: ee093ca70666
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Device: Flame 2.2 (319mb, full flash)
Build ID: 20150211002505
Gaia: 943be6fd146017dcd9d4c9d1027be1e43bad13eb
Gecko: e614443583e7
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Repro frequency: 5/5
See attached: screenshot

Comment 1

[Dylan Oliver [:doliver]]

triage: we have a number of bugs like this, see bug 1126587 comment 15 for some guidance on proper treatment.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] millermedeiros:1132238-rtl-account-truncated > mozilla-b2g:master

Comment 3

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8563776 [details] [review]
[gaia] millermedeiros:1132238-rtl-account-truncated > mozilla-b2g:master

added `[dir="auto"]` for account name on "drawer" and "advanced settings".

Comment 4

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8563776 [details] [review]
[gaia] millermedeiros:1132238-rtl-account-truncated > mozilla-b2g:master

I just r+'d this patch on another bug.

Comment 5

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/caaa106d4b4d79978ed62e0e97af63da673fba0c

Comment 6

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8563776 [details] [review]
[gaia] millermedeiros:1132238-rtl-account-truncated > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): none
[User impact] if declined: RTL users might not be able to identify between 2 accounts since it truncates the user name from the email address
[Testing completed]: manual
[Risk to taking this patch] (and alternatives if risky): low risk
[String changes made]: none

Comment 7

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/fee32b6723207177535d20604724ce3711f61620

Comment 8

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame Master and 2.2.

Result: Truncation occurs at the end of the section, so the email address is truncated.
 
Device: Flame Master (KK, 319mb, full flash)
Build ID: 20150225010244
Gaia: f6bfd854fe4746f21bc006eac145365e85f98808
Gecko: 0a8b3b67715a
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Device: Flame 2.2 (KK, 319mb, full flash)
Build ID: 20150225002505
Gaia: ca64f2fe145909f31af266b1730874051ba76c78
Gecko: 16804008c29f
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 9

[Alissa（leave from Mozilla）]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15912/