1132257 - Update cubeb from upstream

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Matthew Gregan [:kinetik]]

Mostly just formatting changes, but I have taken dmajor's patch from bug 1131871 a step further and (re-)added error checking to COM initialization.  It's a fairly simple change, but it needs a proper review.

Comment 1

[Matthew Gregan [:kinetik]]

Attachment: Update cubeb from upstream

Comment 2

[Matthew Gregan [:kinetik]]

Attachment: Update cubeb from upstream v2

Small refresh to pick up cpeterson's warning fixes and a minor state clearing bug in WASAPI.

Comment 3

[Matthew Gregan [:kinetik]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f8d6a8acb509

Comment 4

[Paul Adenot (:padenot)]

20:50:31 INFO - COM already initialized in STA.
20:50:31 INFO - 1923 INFO TEST-UNEXPECTED-FAIL | dom/media/webaudio/test/test_maxChannelCount.html | We can query the maximum number of channels - expected PASS

Comment 5

[Matthew Gregan [:kinetik]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5e4ad51d30cc

Comment 6

[Matthew Gregan [:kinetik]]

Attachment: Update cubeb from upstream v3

Don't treat COM concurrency model change as an error; fixes timeout in test.

Also adds some error handling around render thread shutdown, and makes the debug logging threadsafe by writing only a single line.

Comment 7

[Matthew Gregan [:kinetik]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9b95a2885023

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9b95a2885023