1132271 - Port bug 1001332 to comm-beta to allow xp to work in Thunderbird beta 36

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Kent James (:rkent)]

In Thunderbird 36 beta builds are not working on XP due to the update to VS 2013. Port the fix done for Firefox in bug 1001332 to Thunderbird.

A patch in Thunderbird 37 makes this unnecessary in subsequent repos, so this should only be landed on comm-central beta for Thunderbird 36.

Comment 1

[Justin Wood (:Callek)]

fwiw my only concern here is that it doesn't break things when built with MSVC2010...

SeaMonkey will be using MSVC2010 for our next beta (Gecko 36) build.

(MSVC2010 is as of this writing broken on beta at present, but not forcefully/intended to be. I have a patch series to push tonight that will fix that)

Comment 2

[Kent James (:rkent)]

Attachment: Set SUBSYSTEM to support XP

Here's the plan if you'd like to comment.

Comment 3

[Kent James (:rkent)]

Comment on attachment 8563155 [details] [diff] [review]
Set SUBSYSTEM to support XP

Hi Callek, perhaps since you had a concern with SeaMonkey and VS 2010 then you could review this and see if it works for you.

Comment 4

[Justin Wood (:Callek)]

Comment on attachment 8563155 [details] [diff] [review]
Set SUBSYSTEM to support XP

While my concern still stands, I won't realistically get to look into this until mid-next week, the earliest. And since it is blocking another [or is it respin?] of TB beta, I might as well redirect to someone more involved with TB and better at build system reviews lately

Comment 5

[Kent James (:rkent)]

Try server build:

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=03538f02f5f3

Comment 6

[Joshua Cranmer [:jcranmer]]

Comment on attachment 8563155 [details] [diff] [review]
Set SUBSYSTEM to support XP

Review of attachment 8563155 [details] [diff] [review]:
-----------------------------------------------------------------

I'm taking the fact that this built on try to be sufficient evidence that it works.

Comment 8

[Kent James (:rkent)]

https://hg.mozilla.org/releases/comm-beta/rev/72cd4a740611

Comment 9

[Kent James (:rkent)]

Comment on attachment 8563155 [details] [diff] [review]
Set SUBSYSTEM to support XP

[Triage Comment] Needed for beta to build