1132287 - Template editing yields server error if the ID is not found

Status: RESOLVED FIXED

(Webtools Graveyard :: Air Mozilla, defect)

Description

[Peter Bengtsson [:peterbe]]

If you go to https://air.mozilla.org/manage/templates/999/ and is not a valid Template id you get an internal server error. 
Instead you should get a 404.

Comment 1

[Gloria Dwomoh]

I want to fix this bug, but tried to reproduce this error and after telling me that I need to sign in to view the page (which I did), it says "Email [my email] authenticated but not vouched for". I tried to see if I got any email to confirm my account but I got none, so I can't really get to reproduce it as it doesn't sign me in. Can you please elaborate where does it fetch the internal server error page from? I looked at the code and through some folders, but I can't seem to figure that out.

PS. I have also submitted a pull request for another bug 3 days ago here [https://github.com/mozilla/airmozilla/pull/223]

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/airmozilla

https://github.com/mozilla/airmozilla/commit/6f1c019cba73caff97513de479f9228e3820cb86
fixes Bug 1132287 - Template editing yields server error if the ID is not found

https://github.com/mozilla/airmozilla/commit/b91107f71ed42eb9e971e374450babd46d8e7106
Merge pull request #229 from aarshvig/patch-6

fixes Bug 1132287 - Template editing yields server error if the ID is no...

Comment 3

[Peter Bengtsson [:peterbe]]

Gloria,
We talked about the unfortunate clash of efforts by email.