Closed Bug 1132305 Opened 5 years ago Closed 5 years ago

BHR does not report Flash Hangs on MacOS

Categories

(Core :: Widget: Cocoa, defect)

x86_64
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox38 --- fixed

People

(Reporter: aklotz, Assigned: aklotz)

References

Details

Attachments

(1 file, 1 obsolete file)

When trying to test my changes for bug 1128768, I was finding that BHR was failing to detect blatant flash hangs. This led me to spending a whole bunch of time tracking this down. I found out that BHR thinks that the main thread is waiting because of an unbalanced call to HangMonitor::Suspend in GeckoNSApplication nextEventMatchingMask.

Apparently the subsequent control flow never involved a call to HangMonitor::NotifyActivity.
Attached patch Patch? (obsolete) — Splinter Review
This patch seems to work, but I'm wondering if this is the right place to put it. I don't know enough about event dispatching on MacOS to know for certain. :-)
Attachment #8563172 - Flags: review?(smichaud)
Component: XPCOM → Widget: Cocoa
Comment on attachment 8563172 [details] [diff] [review]
Patch?

I don't know much about the hang monitor.  But this is probably the right place to make the change.  It's definitely "central" -- all Cocoa event handling for our app goes through here.

I suggest this bake on m-c for at least a few days before getting uplifted.
Attachment #8563172 - Flags: review?(smichaud) → review+
Comment on attachment 8563172 [details] [diff] [review]
Patch?

Review of attachment 8563172 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/cocoa/nsAppShell.mm
@@ +119,1 @@
>            untilDate:expiration inMode:mode dequeue:flag];

nit: vertical alignment
Attached patch PatchSplinter Review
Updated commit message. Carrying forward r+.
Attachment #8563172 - Attachment is obsolete: true
Attachment #8563484 - Flags: review+
Assignee: nobody → aklotz
Status: NEW → ASSIGNED
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c067523b4d1a
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.