Closed
Bug 113234
Opened 23 years ago
Closed 2 years ago
Get rid of (Assign|Append|Insert)WithConversion
Categories
(Core :: XPCOM, enhancement, P3)
Core
XPCOM
Tracking
()
RESOLVED
WORKSFORME
Future
People
(Reporter: jag+mozilla, Unassigned)
References
(Depends on 2 open bugs)
Details
Attachments
(1 file)
2.69 KB,
patch
|
darin.moz
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
For literal strings ("..."), use NS_LITERAL_STRING, for other strings use NS_ConvertASCIItoUCS2 / NS_LossyConvertUCS2toASCII. For the latter two this will result in seemingly an extra copy, but this will be shared once we switch to nsSharableString. The alternative is writing a generator version of our convertors. These generators would generate into the existing buffer if they'd fit and the buffer wasn't shared, and would otherwise have to allocate a new buffer to generate into. All in all they don't seem like much of a win in this case, but are worth investigating later.
Reporter | ||
Comment 2•23 years ago
|
||
The second sweep of this would benefit from bug 114386.
Comment 4•20 years ago
|
||
Updated•20 years ago
|
Attachment #153898 -
Flags: review?(darin)
Comment 5•20 years ago
|
||
Comment on attachment 153898 [details] [diff] [review] kill InsertWithConversion (checked in) r=darin thanks!
Attachment #153898 -
Flags: review?(darin) → review+
Updated•20 years ago
|
Attachment #153898 -
Flags: superreview?(dbaron)
Attachment #153898 -
Flags: superreview?(dbaron) → superreview+
Comment 6•20 years ago
|
||
Comment on attachment 153898 [details] [diff] [review] kill InsertWithConversion (checked in) InsertWithConversion patch checked in
Attachment #153898 -
Attachment description: kill InsertWithConversion → kill InsertWithConversion (checked in)
Updated•15 years ago
|
QA Contact: jag → string
Updated•15 years ago
|
Severity: normal → enhancement
Priority: -- → P3
Updated•13 years ago
|
Assignee | ||
Updated•3 years ago
|
Component: String → XPCOM
Comment 8•2 years ago
|
||
The bug assignee didn't login in Bugzilla in the last 7 months.
:nika, could you have a look please?
For more information, please visit auto_nag documentation.
Assignee: jag+mozilla → nobody
Flags: needinfo?(nika)
Comment 9•2 years ago
|
||
The methods this bug was filed to remove don't appear to exist anymore.
Status: NEW → RESOLVED
Closed: 2 years ago
Flags: needinfo?(nika)
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•