1132347 - mozBackgroundRequest ignore errors only in the main thread

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Masatoshi Kimura [:emk]]

Because it is annotated as [SetterThrows=Workers] while it can actually fail even in the main thread.

Is this intentional? If so, why is it different between the main thread and workers?

Comment 1

[Boris Zbarsky [:bzbarsky]]

This totally looks like a bug.  Should just be SetterThrows.  Want to fix?

Comment 2

[Masatoshi Kimura [:emk]]

Will do.

Comment 3

[Masatoshi Kimura [:emk]]

Attachment: patch

|void SetMozBackgroundRequest(bool, nsresult&)| was not even called, it was not even updated when ErrorResult was introduced. The compiler didn't catch the error because the signature of the XPCOM version (that is, |NS_IMETHODIMP nsXMLHttpRequest::SetMozBackgroundRequest(bool)|) happened to match the signature of the infallible WebIDL setter function (the difference of the return type did not matter).

Is it possible to prevent similar mistakes in the future?

Comment 4

[Masatoshi Kimura [:emk]]

> |void SetMozBackgroundRequest(bool, nsresult&)| was not even called
...from the generated code. It is called from the XPCOM version, of course.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8564126 [details] [diff] [review]
patch

r=me

As far as preventing this in the future, I filed bug 1132934.

Comment 6

[Masatoshi Kimura [:emk]]

Thank you!
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7b73af4a789d

Comment 7

[Masatoshi Kimura [:emk]]

Hm, some tests set mozBackgroundRequest after open() that should have no effect...
/dom/system/NetworkGeolocationProvider.js
/toolkit/components/search/SearchSuggestionController.jsm
/toolkit/identity/Identity.jsm

Comment 8

[Masatoshi Kimura [:emk]]

Fixed by bug 1269162.