Closed Bug 1132370 Opened 9 years ago Closed 9 years ago

Wrong State: Expected 'attached', but current state is 'detached'

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

37 Branch
x86
macOS
defect
Not set
normal

Tracking

(firefox38 fixed, firefox39 fixed)

RESOLVED FIXED
Firefox 39
Tracking Status
firefox38 --- fixed
firefox39 --- fixed

People

(Reporter: jsantell, Assigned: vporof)

References

Details

Attachments

(1 file)

4757 INFO TEST-UNEXPECTED-FAIL | browser/devtools/performance/test/browser_perf-details-memory-calltree-render.js | A promise chain failed to handle a rejection: - Protocol error (unknownError): Error: Wrong State: Expected 'attached', but current state is 'detached'

Only saw this once on gum on linux debug
https://treeherder.mozilla.org/#/jobs?repo=gum&revision=c87fcfad32e4
Summary: INFO TEST-UNEXPECTED-FAIL browser/devtools/performance/test/browser_perf-details-memory-calltree-render.js → Wrong State: Expected 'attached', but current state is 'detached'
A few tests have this on gum, and I've seen it once manually working with it.
4814 INFO TEST-UNEXPECTED-FAIL | browser/devtools/performance/test/browser_perf-overview-render-03.js | A promise chain failed to handle a rejection: - Protocol error (unknownError): Error: Wrong State: Expected 'attached', but current state is 'detached'
4873 INFO TEST-UNEXPECTED-FAIL | browser/devtools/performance/test/browser_perf-refresh.js | A promise chain failed to handle a rejection: - Protocol error (unknownError): Error: Wrong State: Expected 'attached', but current state is 'detached'
This is popping up everywhere in tests.
Blocks: enable-perf-tool
No longer blocks: perf-tool-crashes
Blocks: perf-tool-tests
No longer blocks: enable-perf-tool
Right now, this is one of the most prevalent fails on try. Need to fix this!
s/try/gum/
Any progress on this?
Working on it.
Attached patch v1Splinter Review
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #8573317 - Flags: review?(jsantell)
Comment on attachment 8573317 [details] [diff] [review]
v1

Review of attachment 8573317 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome. Is this worth an uplift to aurora? There's no b2g version based on fx38, but I think that will be an ESR version.
Attachment #8573317 - Flags: review?(jsantell) → review+
(In reply to Jordan Santell [:jsantell] [@jsantell] from comment #9)
> Comment on attachment 8573317 [details] [diff] [review]
> v1
> 
> Review of attachment 8573317 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Awesome. Is this worth an uplift to aurora? There's no b2g version based on
> fx38, but I think that will be an ESR version.

Yeah, sure!
Comment on attachment 8573317 [details] [diff] [review]
v1

Approval Request Comment
[Feature/regressing bug #]: Fixes an intermittent test failure for a (yet to be enabled by default) developer tool. 
[User impact if declined]: Possible backwards incompatibility between the devtools server and client.
[Describe test coverage new/current, TreeHerder]: This fix affects all the tests.
[Risks and why]: No risk.
[String/UUID change made/needed]: None.
Attachment #8573317 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/9da0a1f0e481
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 39
Comment on attachment 8573317 [details] [diff] [review]
v1

Approving for uplift to aurora. Hooray for fixing the tests!
Attachment #8573317 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Keywords: checkin-needed
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: