Closed Bug 1132395 Opened 5 years ago Closed 5 years ago
.create Object URL crashes in Shared Workers in debug builds
No description provided.
The issue here is that we assume that if the worker doesn't have a window, then it's a ChromeWorker. But it can be also a SharedWorker or ServiceWorker, so the assertion has to be removed.
Comment on attachment 8563321 [details] [diff] [review] url.patch Curious, how do we revoke object urls in case of Shared/ServiceWorkers?
Attachment #8563321 - Flags: review?(bugs) → review+
We have a list of URLs in the WorkerPrivate object. When the worker is deleted, we remove those URLs. All of this happens in the main-thread: Here the registration into the WorkerPrivate obj: https://mxr.mozilla.org/mozilla-central/source/dom/workers/URL.cpp#156 Then here we remove those URLs in the main-thread: https://mxr.mozilla.org/mozilla-central/source/dom/workers/WorkerPrivate.cpp#768 https://hg.mozilla.org/integration/mozilla-inbound/rev/6aad679bbbc0
You need to log in before you can comment on or make changes to this bug.