Closed
Bug 11324
Opened 26 years ago
Closed 25 years ago
chrome URLs incorrectly added to global history
Categories
(Core :: DOM: Navigation, defect, P3)
Core
DOM: Navigation
Tracking
()
VERIFIED
FIXED
M14
People
(Reporter: waterson, Assigned: travis)
References
Details
To reproduce:
1. Shutdown browser.
2. Remove [profiledir]/history.mdb
3. Restart browser.
4. Open Tasks->Tools->Manage History
5. Note that there are chrome URLs (and about:blank) in the global history.
Ick!
Fix this, dummy.
Reporter | ||
Updated•26 years ago
|
Status: NEW → ASSIGNED
Target Milestone: M9
Reporter | ||
Comment 1•26 years ago
|
||
Marked assigned too tired to fix tonight.
Chris - I'm helping triage some bugs. Same story as the other history bug -
looks like we could move it out to M10 unless it is very easy and doesn't
interfere with your other M9 work. Move it if you want to.
Reporter | ||
Comment 3•26 years ago
|
||
Move to M10.
Reporter | ||
Updated•25 years ago
|
Target Milestone: M10 → M15
Reporter | ||
Comment 4•25 years ago
|
||
Moving out non-critical tasks.
Updated•25 years ago
|
Component: Browser-General → History
Comment 6•25 years ago
|
||
Chris, take a look at this:
http://lxr.mozilla.org/seamonkey/source/webshell/src/nsWebShell.cpp#3877
Deleting this chunk of bogus code might fix this bug.
Reporter | ||
Comment 7•25 years ago
|
||
Adding pages is a two step process. First step is to call AddPage(), which is
done here:
http://lxr.mozilla.org/mozilla/source/webshell/src/nsWebShell.cpp#1527
Second step is to SetTitle() if it ever arrives, which is the code you pointed
out. If you SetTitle() on a page that has never been added, it turns into a
no-op (I hope). So, I think we're too promiscuous adding pages.
Comment 8•25 years ago
|
||
Can't we do both from navigator.js instead of in the webshell? (That also
prevent things like hiddenwindow.xul from getting put into global history.)
[Or, is there other issues, say with frames?]
Reporter | ||
Updated•25 years ago
|
Target Milestone: M15 → M14
Updated•25 years ago
|
Summary: [history] chrome URLs incorrectly added to global history → chrome URLs incorrectly added to global history
Reporter | ||
Comment 10•25 years ago
|
||
travis: you were gonna fix this somehow, right?
Assignee: waterson → travis
Status: ASSIGNED → NEW
Assignee | ||
Comment 11•25 years ago
|
||
This is already done...
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Component: History: Session → Document Navigation
QA Contact: claudius → docshell
Comment hidden (collapsed) |
You need to log in
before you can comment on or make changes to this bug.
Description
•