Closed Bug 11324 Opened 25 years ago Closed 24 years ago

chrome URLs incorrectly added to global history

Categories

(Core :: DOM: Navigation, defect, P3)

Product:
Core
Component:
DOM: Navigation
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: waterson, Assigned: travis)

References

Details

To reproduce:

1. Shutdown browser.
2. Remove [profiledir]/history.mdb
3. Restart browser.
4. Open Tasks->Tools->Manage History
5. Note that there are chrome URLs (and about:blank) in the global history.
Ick!

Fix this, dummy.
Status: NEW → ASSIGNED
Target Milestone: M9
Marked assigned too tired to fix tonight.
Chris - I'm helping triage some bugs.  Same story as the other history bug -
looks like we could move it out to M10 unless it is very easy and doesn't
interfere with your other M9 work.  Move it if you want to.
Blocks: 11411
Move to M10.
Target Milestone: M10 → M15
Moving out non-critical tasks.
QA Contact: leger → claudius
Updating QA Contact.
Component: Browser-General → History
Chris, take a look at this:

http://lxr.mozilla.org/seamonkey/source/webshell/src/nsWebShell.cpp#3877

Deleting this chunk of bogus code might fix this bug.
Adding pages is a two step process. First step is to call AddPage(), which is
done here:

http://lxr.mozilla.org/mozilla/source/webshell/src/nsWebShell.cpp#1527

Second step is to SetTitle() if it ever arrives, which is the code you pointed
out. If you SetTitle() on a page that has never been added, it turns into a
no-op (I hope). So, I think we're too promiscuous adding pages.
Can't we do both from navigator.js instead of in the webshell?  (That also
prevent things like hiddenwindow.xul from getting put into global history.)
[Or, is there other issues, say with frames?]
Target Milestone: M15 → M14
*** Bug 21709 has been marked as a duplicate of this bug. ***
Summary: [history] chrome URLs incorrectly added to global history → chrome URLs incorrectly added to global history
travis: you were gonna fix this somehow, right?
Assignee: waterson → travis
Status: ASSIGNED → NEW
This is already done...
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
VERIFIED with 2000033009 builds
Status: RESOLVED → VERIFIED
Component: History: Session → Document Navigation
QA Contact: claudius → docshell
You need to log in before you can comment on or make changes to this bug.