Closed
Bug 1132415
Opened 9 years ago
Closed 9 years ago
[mozversion] Expose the package name for local fennec APK file
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(firefox38 fixed)
RESOLVED
FIXED
mozilla38
Tracking | Status | |
---|---|---|
firefox38 | --- | fixed |
People
(Reporter: parkouss, Assigned: parkouss)
References
Details
Attachments
(1 file)
3.36 KB,
patch
|
wlach
:
review+
|
Details | Diff | Splinter Review |
There is a package-name.txt file in APK files that can give information when we want to launch it with mozdevice, eg: adb = ADBAndroid() adb.install_app(apk_filename) adb.launch_fennec(package_name) where package_name here is the information we want, available in package-name.txt file inside the apk file. So let's add a new 'package_name' key in the version info dict returned by LocalFennecVersion to make this information available to mozversion consumers.
Assignee | ||
Comment 1•9 years ago
|
||
I tested it locally with success, and ran unit tests with success too.
Attachment #8563355 -
Flags: review?(wlachance)
Comment 2•9 years ago
|
||
Comment on attachment 8563355 [details] [diff] [review] Expose the package name for local fennec APK file Awesome, thank you!
Attachment #8563355 -
Flags: review?(wlachance) → review+
Comment 3•9 years ago
|
||
I tested this locally and it passes unit tests with flying colors. It shouldn't effect anything else we have running in production. Let's check this in when the trees reopen.
Keywords: checkin-needed
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f9d3dabd12e
Keywords: checkin-needed
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8f9d3dabd12e
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox38:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•