1132419 - [Settings][Privacy Panel] Incorrect Coloured Status bar/icons

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Eric Pang [:epang] UX]

Attachment: Incorrect Status Bar.png

The privacy panel in settings is using the wrong coloured status bar.  Can we update to the light status bar with dark icons (used everyone else in settings).

Comment 1

[Gregor Wagner [:gwagner]]

Wilfred, is this a blocking issue? Do we block on Privacy Panel bugs?

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] gmarty:Bug-1132419-Settings-Privacy-Panel-Incorrect-Coloured-Status-bar-icons > mozilla-b2g:master

Comment 3

[Guillaume Marty [:gmarty]]

Comment on attachment 8564836 [details] [review]
[gaia] gmarty:Bug-1132419-Settings-Privacy-Panel-Incorrect-Coloured-Status-bar-icons > mozilla-b2g:master

Not sure who owns the privacy controls but I saw Kevin merged a few patches, so can you have a look at this one?

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8564836 [details] [review]
[gaia] gmarty:Bug-1132419-Settings-Privacy-Panel-Incorrect-Coloured-Status-bar-icons > mozilla-b2g:master

Sure, looks good to me. Thanks!

Comment 5

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Comment 6

[Kevin Grandon :kgrandon]

Oh right, no component for privacy panel yet =(  But I've been reviewing a few of these patches, so I feel fine landing this.

In master: https://github.com/mozilla-b2g/gaia/commit/2d0e3d20af4c4ea66bd4c2a979067dd8ea7a722c

Comment 7

[Michael Henretty [:mikehenrty][:mhenretty]]

Guillaume, even though it's not marked as blocking let's request uplift since it's low risk.

Comment 8

[Candice Serran (:cserran)]

Not a blocker to release but will request uplift for approval

Comment 9

[Guillaume Marty [:gmarty]]

Comment on attachment 8564836 [details] [review]
[gaia] gmarty:Bug-1132419-Settings-Privacy-Panel-Incorrect-Coloured-Status-bar-icons > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Privacy controls
[User impact] if declined: The Privacy Controls app has a different colour theme than the Settings app resulting in a non intuitive UI
[Testing completed]: Manual testing
[Risk to taking this patch] (and alternatives if risky): Very low, just a HTML meta added.
[String changes made]: None

Comment 10

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/c9d22f4e95122bd23db744c8ac4df444eaf77cef

Comment 11

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed in the latest Nightly 3.0 and 2.2 Flame builds.  

Results:  Status bar is a light grey color.

Environmental Variables:
Device: Flame 3.0 KK (319MB) (Full Flash)
BuildID: 20150219010228
Gaia: 620aecfde85a8b093247837c55de2708e22be1e1
Gecko: 360b5f211180
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Environmental Variables:
Device: Flame 2.2 KK (319MB) (Full Flash)
BuildID: 20150219002504
Gaia: ce79d35b92261e7cbfeaefebf87859ebeb0979b4
Gecko: 159a3907b959
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0