If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Get rid of (Compare|Equals)WithConversion

RESOLVED FIXED in mozilla1.8alpha3

Status

()

Core
String
RESOLVED FIXED
16 years ago
4 years ago

People

(Reporter: jag (Peter Annema), Assigned: Biesinger)

Tracking

Trunk
mozilla1.8alpha3
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

16 years ago
Replace them with the appropriate Compare / Equals and convertors.

We can later look into using generators for these, which could do on-demand
character conversions as the search algorithm asks for them. We'd have to expand
string generators though to support this.
(Reporter)

Updated

16 years ago
Blocks: 113229
(Reporter)

Comment 1

16 years ago
The second sweep of this would benefit from bug 114386.
(Reporter)

Comment 2

16 years ago
-> future
Target Milestone: --- → Future
Created attachment 153716 [details] [diff] [review]
patch for callers (checked in)

note: this patch only kills callers of equals/comparewithconversion
Assignee: jag → cbiesinger
Status: NEW → ASSIGNED
Attachment #153716 - Flags: review?(roc)
Attachment #153716 - Flags: superreview+
Attachment #153716 - Flags: review?(roc)
Attachment #153716 - Flags: review+
Attachment #153716 - Attachment description: patch for callers → patch for callers (checked in)
Created attachment 153945 [details] [diff] [review]
kill impl
Attachment #153945 - Flags: review?(darin)
Target Milestone: Future → mozilla1.8alpha3

Updated

13 years ago
Attachment #153945 - Flags: review?(darin) → review+
Attachment #153945 - Flags: superreview?(dbaron)
Attachment #153945 - Flags: superreview?(dbaron) → superreview+
Checking in public/nsTString.h;
/cvsroot/mozilla/xpcom/string/public/nsTString.h,v  <--  nsTString.h
new revision: 1.15; previous revision: 1.14
done
Checking in src/nsStringObsolete.cpp;
/cvsroot/mozilla/xpcom/string/src/nsStringObsolete.cpp,v  <--  nsStringObsolete.cpp
new revision: 1.13; previous revision: 1.12
done
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.