1132636 - rbbz: users created from bugzilla do not have is_private set True until the second time they are accessed

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect, P2)

Description

[Dan Minor [:dminor]]

It appears the intention is to always set is_private to True for users created from bugzilla [1].

Because this is done in the else part of a try/except/else clause, and the user is created in the except clause, is_private is not actually set until the second time the user is accessed.

[1] https://dxr.mozilla.org/hgcustom:version-control-tools/source/pylib/rbbz/rbbz/models.py#88

Comment 1

[Dan Minor [:dminor]]

Attachment: MozReview Request: bz://1132636/dminor

/r/3841 - vcttesting: add mach command to dump reviewboard account profile; r=gps
/r/3843 - rbbz: set is_private to true when creating the user (bug 1132636); r=mconley

Pull down these commits:

hg pull review -r ab5a15efc10174670d7d052c6c9239edc035c344

Comment 2

[Mike Conley (:mconley) (:⚙️)]

https://reviewboard.mozilla.org/r/3843/#review3057

Ship It!

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8564121 [details]
MozReview Request: bz://1132636/dminor

https://reviewboard.mozilla.org/r/3839/#review3059

Ship It!

Comment 4

[Gregory Szorc [:gps]]

https://reviewboard.mozilla.org/r/3841/#review3127

Ship It!

Comment 5

[Gregory Szorc [:gps]]

https://reviewboard.mozilla.org/r/3843/#review3129

::: hgext/reviewboard/tests/test-auth.t
(Diff revision 1)
> +  $ rbmanage make-admin $BUGZILLA_USERNAME

Is this still necessary? The newly-added make-admin command accesses the DB directly and doesn't need admin privileges.

What breaks if this is removed?

Comment 6

[Gregory Szorc [:gps]]

Comment on attachment 8564121 [details]
MozReview Request: bz://1132636/dminor

https://reviewboard.mozilla.org/r/3839/#review3131

Ship It!

Comment 7

[Dan Minor [:dminor]]

https://reviewboard.mozilla.org/r/3843/#review3141

> Is this still necessary? The newly-added make-admin command accesses the DB directly and doesn't need admin privileges.
> 
> What breaks if this is removed?

This makes the user a reviewboard admin. We need it because dump-user uses the Reviewboard API (not the database) and with accounts now set to private on creation we would no longer see the user name and email in this test unless our API user is an admin.

An alternative would be to change dump-user to read the reviewboard auth database table rather than query through the API.

Comment 8

[Gregory Szorc [:gps]]

https://reviewboard.mozilla.org/r/3843/#review3143

> This makes the user a reviewboard admin. We need it because dump-user uses the Reviewboard API (not the database) and with accounts now set to private on creation we would no longer see the user name and email in this test unless our API user is an admin.
> 
> An alternative would be to change dump-user to read the reviewboard auth database table rather than query through the API.

I see. This is OK, then.

Ship it.

Comment 9

[Dan Minor [:dminor]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/8a07371eafc1
https://hg.mozilla.org/hgcustom/version-control-tools/rev/1927427a46a0

Comment 11

[Dan Minor [:dminor]]

Attachment: MozReview Request: vcttesting: add mach command to dump reviewboard account profile; r=gps

Comment 12

[Dan Minor [:dminor]]

Attachment: MozReview Request: rbbz: set is_private to true when creating the user (bug 1132636); r=mconley