1132645 - Convert Mozmill test 'remote/testSecurity/testDVCertificate.js' to Marionette

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, defect, P1)

Description

[Barbara Miller (:galgeek)]

This bug will cover the necessary work to convert the following test into Marionette.

http://hg.mozilla.org/qa/mozmill-tests/file/default/firefox/tests/remote/testSecurity/testDVCertificate.js

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Most of the security tests will be blocked on the security module and the page info window module. I will mark them as dependencies here. 

Barbara, can you please check all the other remote security tests and add similar dependencies please? thanks.

Comment 2

[Barbara Miller (:galgeek)]

Yes, I'll update the dependencies.

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Attachment: PR with converted test

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8579070 [details] [review]
PR with converted test

For comments please see the PR.

Comment 5

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8579070 [details] [review]
PR with converted test

Comments addressed.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8579070 [details] [review]
PR with converted test

You can leave the previous feedback. That way we can see the amount of cycles we went through.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8579070 [details] [review]
PR with converted test

Some updates are left to do.

Comment 8

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8579070 [details] [review]
PR with converted test

Updated with changes.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8579070 [details] [review]
PR with converted test

r- because the test is failing in at least 2 areas. Only small changes left before we can land it.

Comment 10

[Chris Manchester (limited bugmail, email directly)]

(In reply to Henrik Skupin (:whimboo) from comment #9)
> Comment on attachment 8579070 [details] [review]
> PR with converted test
> 
> r- because the test is failing in at least 2 areas. Only small changes left
> before we can land it.

I would expect this to fail before bug 1144907 reaches nightly.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

That's in Nightly builds since yesterday already.

Comment 12

[Chris Manchester (limited bugmail, email directly)]

https://github.com/mozilla/firefox-ui-tests/commit/5c2d041d0505272f9a81de04cf173adc1e1af76c