1132646 - [RTL][Contacts][Labels] When the user changes a Label in the contacts app the previously used label will move forward

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Contacts, defect, P2)

Description

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Attachment: Contacts Label Logcat

Description:
If the user deselects a label option when editing or creating a new contact, the text will visibly shift forward slightly

Prerequisites: Have device set to an RTL language, such as Arabic (عربي)

Repro Steps:
1) Update a Flame to 20150212010213
2) Open Contacts App> Tap on "+" to add a new contact
3) Select any Label from one of the subjects, such as the phone number section
4) select a different label than the one selected by default
5) Observe the previously selected Label


Actual:
Texts moves forward slightly


Expected:
The text does not move when it is unselected

Environmental Variables:
Device: Flame 3.0 (319mb)(Kitkat)(Full Flash)
Build ID: 20150212010213
Gaia: d5a71cedb37dd45f439f672489db3994b349ac43
Gecko: 3094601af679
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Repro frequency: 15/15
See attached: Logcat, Video - http://youtu.be/bP1DGjAd9I4

Comment 1

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

This issue does NOT occur on Flame 2.2

The text does not shift when the option is deselected

Environmental Variables:
Device: Flame 2.2 (319mb)(Kitkat)(Full Flash)
Build ID: 20150212002504
Gaia: 791e53728cd8018f1d7cf7efe06bbeb1179f0370
Gecko: 5dec207fcbeb
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[Dylan Oliver [:doliver]]

RTL triage: This is a P2 strictly for RTL but it might warrant more attention because of the regression. 

I find the flashing of the label when you press it far more distracting than the pixel shift -- is that new too?

Comment 3

[Peter Bylenga [:PBylenga]]

[Blocking Requested - why for this release]:
Regression of a supported feature.

Requesting a window.

Comment 4

[Augustin Trancart [:autra]]

I confirm this only reproduces with gecko 37 (latest gaia master).  

By the way, the shift I see is far worse than in the video. Imho what happens is that the -moz-padding-end is added at the right (so the "start" in rtl) instead of being added at the left in case of rtl element.

Clearing assignment, as I won't be able to fix it on gaia.

Comment 5

[Brogan Zumwalt [Inactive]]

Mozilla-Inbound Regression Window:

Last working Mozilla-Inbound build:
Device: Flame 3.0
Build ID: 20150209063429
Gaia: 0d7b35f23402c4cb29bca6b98280fec48a196dec
Gecko: c13e7799a147
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

First broken Mozilla-Inbound build:
Device: Flame 3.0
Build ID: 20150209064732
Gaia: 0d7b35f23402c4cb29bca6b98280fec48a196dec
Gecko: 70a1847bdc20
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0


Working Gaia with Broken Gecko issue DOES occur:
Gaia: 0d7b35f23402c4cb29bca6b98280fec48a196dec
Gecko: 70a1847bdc20

Working Gecko with Broken Gaia issue does NOT occur:
Gaia: 0d7b35f23402c4cb29bca6b98280fec48a196dec
Gecko: c13e7799a147


Mozilla-Inbound Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=c13e7799a147&tochange=70a1847bdc20


Issue appears to occur due to changes made in bug 1130231

Comment 6

[KTucker [:KTucker][Inactive 3/4/2016]]

Jonathan, can you take a look at this please? Looks like the work done on bug 1130231 might have caused this issue to occur.

Comment 7

[Jonathan Kew [:jfkthame]]

I can't reproduce this in my local build (GP Peak), leading me to suspect that it may have been resolved already by one of the recent RTL button-padding fixes. Please re-test with latest Gecko and Gaia revisions, and confirm whether the issue still exists.

Comment 8

[Brogan Zumwalt [Inactive]]

May just have gotten fixed, the latest Flame 3.0 nightly still repros (Gecko version: 4bb425001d8a), but does NOT occur in latest Mozilla-Central build (maybe due to your changes in bug 1132186?)

Alternating between label choices while editing contact shows no shifting text when language is set to Arabic.

Device: Flame 3.0
Build ID: 20150217112337
Gaia: 4f39e48b95fa00c8669b8707447542024bb55432
Gecko: 7f7e833005ea
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Hi,

I've just tried this and works for me.

Comment 10

[Augustin Trancart [:autra]]

I don't believe that bug 1132186 fixed this. It was a gecko issue according to me : -moz-padding-start was padding stuff to the left instead of the right in RTL. (I checked this with the webIDE). But the important point is that it is fixed :-)