Closed Bug 1132650 Opened 9 years ago Closed 9 years ago

Add pacific_day to tzone.py

Categories

(Release Engineering :: General, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: armenzg, Assigned: armenzg)

Details

Attachments

(2 files, 1 obsolete file)

Attached patch tzone.diff (obsolete) — Splinter Review
I'm using this code in mozilla_ci_tools.

I'm adding pacific_day if you want to add this change to buildapi even if not used.
You can say 'no'. I just want to keep them synced.
Attachment #8563620 - Flags: review?(catlee)
Attached patch tzone.diffSplinter Review
As committed.
Attachment #8563620 - Attachment is obsolete: true
Attachment #8563620 - Flags: review?(catlee)
Attachment #8564186 - Flags: review?(catlee)
Comment on attachment 8564186 [details] [diff] [review]
tzone.diff

Review of attachment 8564186 [details] [diff] [review]:
-----------------------------------------------------------------

looks fine to me
Attachment #8564186 - Flags: review?(catlee) → review+
https://hg.mozilla.org/build/buildapi/rev/fd37453372c3

Thank you!
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
I made these changes for mozci and thought of sharing them.
Attachment #8568920 - Flags: review?(catlee)
Attachment #8568920 - Flags: review?(catlee) → review+
Instead of backporting. Here's where we might be making improvements:
https://github.com/armenzg/mozilla_ci_tools/blob/master/mozci/utils/tzone.py
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
Component: Tools → General
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: