1132652 - Support Windows 10 (Windows NT 10.0) reporting

Status: RESOLVED FIXED

(Socorro :: Database, task)

Description

[Robert Kaiser]

+++ This bug was initially created as a clone of Bug #1076270 +++

The newer Windows 10 Preview available now seems to have changed the Windows version, see bp-316b99cd-ae77-41e8-8e6f-1c8ee2150212

So we'll need to add the mapping for Windows NT 10.0.x to Windows 10 in Socorro as well to have it not appear as "Windows Unknown" in reports.

Comment 1

[Robert Kaiser]

And just to be sure, as the above report is from a 64bit Nightly, I also tried Beta (32bit) and it shows the same versions for Windows: bp-58bba3ae-4cae-4192-94f6-8f42e2150212

Comment 2

[Selena Deckelmann :selenamarie :selena]

breakpad=# select * from windows_versions ; 
 windows_version_name | major_version | minor_version 
----------------------+---------------+---------------
 Windows NT           |             3 |             5
 Windows NT           |             4 |             0
 Windows 98           |             4 |             1
 Windows Me           |             4 |             9
 Windows 2000         |             5 |             0
 Windows XP           |             5 |             1
 Windows Vista        |             6 |             0
 Windows 7            |             6 |             1
 Windows 8            |             6 |             2
 Windows 8.1          |             6 |             3
(10 rows)

breakpad=# insert into windows_versions values('Windows 10', 10, 0); 
INSERT 0 1
breakpad=# select * from windows_versions ; 
 windows_version_name | major_version | minor_version 
----------------------+---------------+---------------
 Windows NT           |             3 |             5
 Windows NT           |             4 |             0
 Windows 98           |             4 |             1
 Windows Me           |             4 |             9
 Windows 2000         |             5 |             0
 Windows XP           |             5 |             1
 Windows Vista        |             6 |             0
 Windows 7            |             6 |             1
 Windows 8            |             6 |             2
 Windows 8.1          |             6 |             3
 Windows 10           |            10 |             0
(11 rows)

Comment 3

[Robert Kaiser]

I'm reopening this because on pages like https://crash-stats.mozilla.com/report/list?signature=d3d11.dll%400x86b9 or https://crash-stats.mozilla.com/report/list?signature=d3d11.dll%400x2e3a5 we still have "Windows Unknown" shown instead of "Windows 10".

We need to find what's wrong still and get it fixed properly.

Comment 4

[Robert Kaiser]

Rob, now that Win10 has officially been released, can we please get this fixed? We'll see more and more reports on that version from now on.

Comment 5

[Robert Helmer [:rhelmer]]

Lonnen can we get someone to look into why Windows 10 shows up as "Windows Unknown"?

Selena added the major/minor version in comment 2 that we expected but perhaps it changed.

Comment 6

[Lonnen :lonnen]

PeterBe -- can you have a look?

Comment 7

[Peter Bengtsson [:peterbe]]

Kairo, 
Sorry if you have to explain this again but I'm not sure where the problem is. By saying that I don't even know a place where it *is* working. 

Your links from two months ago (https://crash-stats.mozilla.com/report/list?signature=d3d11.dll%400x86b9 and https://crash-stats.mozilla.com/report/list?signature=d3d11.dll%400x2e3a5) show up nothing.

Comment 8

[Peter Bengtsson [:peterbe]]

Attachment: Link to Github pull-request: https://github.com/mozilla/socorro/pull/2949

Comment 9

[Peter Bengtsson [:peterbe]]

Attachment: Link to Github pull-request: https://github.com/mozilla/socorro/pull/2968

Comment 10

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/8598c6d37aefcae69826b43367265cd89f3a9ea9
fixes bug 1132652 - Windows 10, not Windows Unknown, r=twobraids

https://github.com/mozilla/socorro/commit/0ba77edb4a91908a884ec0bd79f7e6e9216bd406
Merge pull request #2968 from peterbe/bug-1132652-windows-10-not-windows-unknown

fixes bug 1132652 - Windows 10, not Windows Unknown

Comment 11

[Peter Bengtsson [:peterbe]]

Migrations don't get automatically run, so I'll leave it open till then.

Comment 12

[Peter Bengtsson [:peterbe]]

I ran the migrations manually. It solved the problem.