Closed Bug 1132657 Opened 5 years ago Closed 5 years ago

Show JIT flags in jstest.py output.

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox38 --- fixed

People

(Reporter: arai, Assigned: arai)

Details

Attachments

(1 file)

Running jstests.py with --tbpl may show same filename mutliple times, but without any other information for each (bug 1131988).

> REGRESSIONS
>     ecma_5/Function/builtin-no-construct.js
>     ecma_5/Function/builtin-no-construct.js
>     ecma_5/misc/new-with-non-constructor.js
>     ecma_5/misc/new-with-non-constructor.js

It should be nice to show JIT flags for each failure, like jit_test.py does.

> REGRESSIONS
>     --ion-eager --ion-offthread-compile=off ecma_5/Function/builtin-no-construct.js
>     --ion-eager --ion-offthread-compile=off --ion-check-range-analysis --no-sse3 --no-threads ecma_5/Function/builtin-no-construct.js
>     --ion-eager --ion-offthread-compile=off ecma_5/misc/new-with-non-constructor.js
>     --ion-eager --ion-offthread-compile=off --ion-check-range-analysis --no-sse3 --no-threads ecma_5/misc/new-with-non-constructor.js

this would help bug 1101662.
Oops, different format is used in tinderbox :/

Anyway, updating both would be nice.
Summary: Show JIT flags in jstest.py regression/timeout output. → Show JIT flags in jstest.py output.
Updated console output for --tinderbox too.

> TEST-PASS | ecma_5/Function/builtin-no-construct.js | (args: "--baseline-eager")
> TEST-PASS | ecma_5/Function/builtin-no-construct.js | (args: "")
> ## ecma_5/Function/builtin-no-construct.js: rc = 3, run time = 0.035020
> ecma_5/Function/builtin-no-construct.js:11:8 Error: Assertion failed: got "function atan() {\n    [native code]\n} is not a constructor", expected "method is not a constructor"
> TEST-UNEXPECTED-FAIL | ecma_5/Function/builtin-no-construct.js | (args: "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --no-sse3 --no-threads")
> ## ecma_5/Function/builtin-no-construct.js: rc = 3, run time = 0.039450
> ecma_5/Function/builtin-no-construct.js:11:8 Error: Assertion failed: got "function atan() {\n    [native code]\n} is not a constructor", expected "method is not a constructor"
> TEST-UNEXPECTED-FAIL | ecma_5/Function/builtin-no-construct.js | (args: "--ion-eager --ion-offthread-compile=off")
> TEST-PASS | ecma_5/Function/builtin-no-construct.js | (args: "--baseline-eager --no-fpu")
> TEST-PASS | ecma_5/Function/builtin-no-construct.js | (args: "--no-baseline --no-ion")
Attachment #8563671 - Flags: review?(terrence)
Comment on attachment 8563671 [details] [diff] [review]
Show JIT flags in jstests.py output.

Review of attachment 8563671 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! Thanks for doing this.
Attachment #8563671 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/2c72917f420b
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Assignee: nobody → arai.unmht
You need to log in before you can comment on or make changes to this bug.