1132657 - Show JIT flags in jstest.py output.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Tooru Fujisawa [:arai]]

Running jstests.py with --tbpl may show same filename mutliple times, but without any other information for each (bug 1131988).

> REGRESSIONS
>     ecma_5/Function/builtin-no-construct.js
>     ecma_5/Function/builtin-no-construct.js
>     ecma_5/misc/new-with-non-constructor.js
>     ecma_5/misc/new-with-non-constructor.js

It should be nice to show JIT flags for each failure, like jit_test.py does.

> REGRESSIONS
>     --ion-eager --ion-offthread-compile=off ecma_5/Function/builtin-no-construct.js
>     --ion-eager --ion-offthread-compile=off --ion-check-range-analysis --no-sse3 --no-threads ecma_5/Function/builtin-no-construct.js
>     --ion-eager --ion-offthread-compile=off ecma_5/misc/new-with-non-constructor.js
>     --ion-eager --ion-offthread-compile=off --ion-check-range-analysis --no-sse3 --no-threads ecma_5/misc/new-with-non-constructor.js

this would help bug 1101662.

Comment 1

[Tooru Fujisawa [:arai]]

Oops, different format is used in tinderbox :/

Anyway, updating both would be nice.

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Show JIT flags in jstests.py output.

Updated console output for --tinderbox too.

> TEST-PASS | ecma_5/Function/builtin-no-construct.js | (args: "--baseline-eager")
> TEST-PASS | ecma_5/Function/builtin-no-construct.js | (args: "")
> ## ecma_5/Function/builtin-no-construct.js: rc = 3, run time = 0.035020
> ecma_5/Function/builtin-no-construct.js:11:8 Error: Assertion failed: got "function atan() {\n    [native code]\n} is not a constructor", expected "method is not a constructor"
> TEST-UNEXPECTED-FAIL | ecma_5/Function/builtin-no-construct.js | (args: "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --no-sse3 --no-threads")
> ## ecma_5/Function/builtin-no-construct.js: rc = 3, run time = 0.039450
> ecma_5/Function/builtin-no-construct.js:11:8 Error: Assertion failed: got "function atan() {\n    [native code]\n} is not a constructor", expected "method is not a constructor"
> TEST-UNEXPECTED-FAIL | ecma_5/Function/builtin-no-construct.js | (args: "--ion-eager --ion-offthread-compile=off")
> TEST-PASS | ecma_5/Function/builtin-no-construct.js | (args: "--baseline-eager --no-fpu")
> TEST-PASS | ecma_5/Function/builtin-no-construct.js | (args: "--no-baseline --no-ion")

Comment 3

[Terrence Cole [:terrence]]

Comment on attachment 8563671 [details] [diff] [review]
Show JIT flags in jstests.py output.

Review of attachment 8563671 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! Thanks for doing this.

Comment 4

[Tooru Fujisawa [:arai]]

Thank you! :D
https://hg.mozilla.org/integration/mozilla-inbound/rev/2c72917f420b

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2c72917f420b