Closed
Bug 1132674
Opened 10 years ago
Closed 10 years ago
Reader mode toolbar button is slow to appear
Categories
(Firefox :: General, defect, P2)
Firefox
General
Tracking
()
People
(Reporter: Margaret, Assigned: Margaret)
References
Details
Attachments
(1 file, 1 obsolete file)
This is an issue madhava complained about, but I didn't see a bug go by yet.
Right now we wait until pageshow to start parsing the content:
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/content.js#509
We could probably try doing this on DOMContentLoaded instead.
This is an interesting issue because the UX is different than Android, where the reader mode icon replaces the stop button. On Android, if we know about the reader-mode-ability of a page before it's done loading, we still wouldn't show something to the user. But on desktop, we should try to make that reader mode button appear ASAP.
Assignee | ||
Updated•10 years ago
|
Flags: firefox-backlog?
Updated•10 years ago
|
Priority: -- → P2
Assignee | ||
Comment 2•10 years ago
|
||
With the change to avoid parse-on-load (bug 1139678), we could definitely show the button earlier. With my patch in bug 1139678, I'm only using the URL to decide whether or not to show the button, so we could even show it on location change, not pageshow.
Assignee: nobody → margaret.leibovic
Updated•10 years ago
|
Flags: firefox-backlog? → firefox-backlog+
Assignee | ||
Comment 3•10 years ago
|
||
/r/5637 - Bug 1132674 - Show reader toolbar button on DOMContentLoaded instead of pageshow. r=Gijs
Pull down this commit:
hg pull review -r da77ba76b2e0284da630bb1dfec51b24ab9b8e68
Attachment #8579460 -
Flags: review?(gijskruitbosch+bugs)
Comment 4•10 years ago
|
||
Comment on attachment 8579460 [details]
MozReview Request: bz://1132674/margaret
https://reviewboard.mozilla.org/r/5635/#review4617
Ship It!
Attachment #8579460 -
Flags: review?(gijskruitbosch+bugs) → review+
Assignee | ||
Comment 5•10 years ago
|
||
Comment 6•10 years ago
|
||
Is the DOMContentLoaded event fired when a page is reloaded from the bfcache?
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
Updated•10 years ago
|
Iteration: --- → 39.2 - 23 Mar
Flags: qe-verify?
Comment 8•10 years ago
|
||
status-firefox38:
--- → fixed
Assignee | ||
Comment 9•10 years ago
|
||
Attachment #8579460 -
Attachment is obsolete: true
Attachment #8619468 -
Flags: review+
Assignee | ||
Comment 10•10 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•