Closed Bug 1132674 Opened 8 years ago Closed 8 years ago

Reader mode toolbar button is slow to appear

Categories

(Firefox :: General, defect, P2)

Product:
Firefox
Component:
General
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 39
Iteration:
39.2 - 23 Mar
Tracking Flags:
Tracking Status
firefox38 --- fixed
firefox39 --- fixed

People

(Reporter: Margaret, Assigned: Margaret)

References

Details

Attachments

(1 file, 1 obsolete file)

MozReview Request: Bug 1132674 - Show reader toolbar button on DOMContentLoaded instead of pageshow. r=Gijs
39 bytes, text/x-review-board-request
Gijs
: review+
Details 
This is an issue madhava complained about, but I didn't see a bug go by yet.

Right now we wait until pageshow to start parsing the content:
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/content.js#509

We could probably try doing this on DOMContentLoaded instead.

This is an interesting issue because the UX is different than Android, where the reader mode icon replaces the stop button. On Android, if we know about the reader-mode-ability of a page before it's done loading, we still wouldn't show something to the user. But on desktop, we should try to make that reader mode button appear ASAP.
Flags: firefox-backlog?
Priority: -- → P2
With the change to avoid parse-on-load (bug 1139678), we could definitely show the button earlier. With my patch in bug 1139678, I'm only using the URL to decide whether or not to show the button, so we could even show it on location change, not pageshow.
Assignee: nobody → margaret.leibovic
Flags: firefox-backlog? → firefox-backlog+
/r/5637 - Bug 1132674 - Show reader toolbar button on DOMContentLoaded instead of pageshow. r=Gijs

Pull down this commit:

hg pull review -r da77ba76b2e0284da630bb1dfec51b24ab9b8e68
Attachment #8579460 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8579460 [details]
MozReview Request: bz://1132674/margaret

https://reviewboard.mozilla.org/r/5635/#review4617

Ship It!
Attachment #8579460 - Flags: review?(gijskruitbosch+bugs) → review+
Is the DOMContentLoaded event fired when a page is reloaded from the bfcache?
Depends on: 1145259
https://hg.mozilla.org/mozilla-central/rev/5bdecf0d7d63
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
Iteration: --- → 39.2 - 23 Mar
Flags: qe-verify?

        Attachment #8579460 -
        Attachment is obsolete: true

        Attachment #8619468 -
        Flags: review+

          You need to log in
          before you can comment on or make changes to this bug.