1132674 - Reader mode toolbar button is slow to appear

Status: RESOLVED FIXED

(Firefox :: General, defect, P2)

Description

[:Margaret Leibovic]

This is an issue madhava complained about, but I didn't see a bug go by yet.

Right now we wait until pageshow to start parsing the content:
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/content.js#509

We could probably try doing this on DOMContentLoaded instead.

This is an interesting issue because the UX is different than Android, where the reader mode icon replaces the stop button. On Android, if we know about the reader-mode-ability of a page before it's done loading, we still wouldn't show something to the user. But on desktop, we should try to make that reader mode button appear ASAP.

Comment 2

[:Margaret Leibovic]

With the change to avoid parse-on-load (bug 1139678), we could definitely show the button earlier. With my patch in bug 1139678, I'm only using the URL to decide whether or not to show the button, so we could even show it on location change, not pageshow.

Comment 3

[:Margaret Leibovic]

Attachment: MozReview Request: bz://1132674/margaret

/r/5637 - Bug 1132674 - Show reader toolbar button on DOMContentLoaded instead of pageshow. r=Gijs

Pull down this commit:

hg pull review -r da77ba76b2e0284da630bb1dfec51b24ab9b8e68

Comment 4

[:Gijs (he/him)]

Comment on attachment 8579460 [details]
MozReview Request: bz://1132674/margaret

https://reviewboard.mozilla.org/r/5635/#review4617

Ship It!

Comment 5

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/5bdecf0d7d63

Comment 6

[Florian Quèze [:florian]]

Is the DOMContentLoaded event fired when a page is reloaded from the bfcache?

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5bdecf0d7d63

Comment 8

[(parental leave 10/24-mid-February) Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2b44abf2f570

Comment 10

[:Margaret Leibovic]

Attachment: MozReview Request: Bug 1132674 - Show reader toolbar button on DOMContentLoaded instead of pageshow. r=Gijs