Closed
Bug 1132679
Opened 9 years ago
Closed 9 years ago
Enable fail on warnings on windows widget
Categories
(Core :: Widget: Win32, defect)
Tracking
()
RESOLVED
FIXED
mozilla38
Tracking | Status | |
---|---|---|
firefox38 | --- | fixed |
People
(Reporter: xidorn, Assigned: xidorn)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
5.03 KB,
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
Fix remaining build warnings in widget/windows and enable FAIL_ON_WARNINGS on that dir.
Assignee | ||
Comment 1•9 years ago
|
||
Assignee: nobody → quanxunzhen
Attachment #8563660 -
Flags: review?(jmathies)
Assignee | ||
Comment 2•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5082165b9f5d
Comment 3•9 years ago
|
||
Comment on attachment 8563660 [details] [diff] [review] patch Review of attachment 8563660 [details] [diff] [review]: ----------------------------------------------------------------- ::: widget/windows/nsFilePicker.cpp @@ +639,5 @@ > > +/* static */ bool > +nsFilePicker::GetFileNameWrapper(OPENFILENAMEW* ofn, PickerType aType) > +{ > + MOZ_SEH_TRY { I think we can just get rid of this trap. If we remove that, can we put this back down in FilePickerWrapper?
Assignee | ||
Comment 4•9 years ago
|
||
(In reply to Jim Mathies [:jimm] from comment #3) > Comment on attachment 8563660 [details] [diff] [review] > patch > > Review of attachment 8563660 [details] [diff] [review]: > ----------------------------------------------------------------- > > ::: widget/windows/nsFilePicker.cpp > @@ +639,5 @@ > > > > +/* static */ bool > > +nsFilePicker::GetFileNameWrapper(OPENFILENAMEW* ofn, PickerType aType) > > +{ > > + MOZ_SEH_TRY { > > I think we can just get rid of this trap. If we remove that, can we put this > back down in FilePickerWrapper? Yes, I think so.
Assignee | ||
Comment 5•9 years ago
|
||
But I wonder whether we can get rid of the trap, given there are some discussion in the API page mentioned that it could raise exception. [1] [1] https://msdn.microsoft.com/en-us/library/windows/desktop/ms646927%28v=vs.85%29.aspx
Comment 6•9 years ago
|
||
Comment on attachment 8563660 [details] [diff] [review] patch yeah you're right. There are a few mentions of exception problems out there, none very clear on what happens. I guess we'll have to keep this.
Attachment #8563660 -
Flags: review?(jmathies) → review+
Assignee | ||
Comment 7•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7d7c3210ea78
Comment 8•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7d7c3210ea78
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox38:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•