1132679 - Enable fail on warnings on windows widget

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Xidorn Quan [:xidorn] UTC+10]

Fix remaining build warnings in widget/windows and enable FAIL_ON_WARNINGS on that dir.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Attachment: patch

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5082165b9f5d

Comment 3

[Jim Mathies [:jimm]]

Comment on attachment 8563660 [details] [diff] [review]
patch

Review of attachment 8563660 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/windows/nsFilePicker.cpp
@@ +639,5 @@
>  
> +/* static */ bool
> +nsFilePicker::GetFileNameWrapper(OPENFILENAMEW* ofn, PickerType aType)
> +{
> +  MOZ_SEH_TRY {

I think we can just get rid of this trap. If we remove that, can we put this back down in FilePickerWrapper?

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

(In reply to Jim Mathies [:jimm] from comment #3)
> Comment on attachment 8563660 [details] [diff] [review]
> patch
> 
> Review of attachment 8563660 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: widget/windows/nsFilePicker.cpp
> @@ +639,5 @@
> >  
> > +/* static */ bool
> > +nsFilePicker::GetFileNameWrapper(OPENFILENAMEW* ofn, PickerType aType)
> > +{
> > +  MOZ_SEH_TRY {
> 
> I think we can just get rid of this trap. If we remove that, can we put this
> back down in FilePickerWrapper?

Yes, I think so.

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

But I wonder whether we can get rid of the trap, given there are some discussion in the API page mentioned that it could raise exception. [1]

[1] https://msdn.microsoft.com/en-us/library/windows/desktop/ms646927%28v=vs.85%29.aspx

Comment 6

[Jim Mathies [:jimm]]

Comment on attachment 8563660 [details] [diff] [review]
patch

yeah you're right. There are a few mentions of exception problems out there, none very clear on what happens. I guess we'll have to keep this.

Comment 7

[Xidorn Quan [:xidorn] UTC+10]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7d7c3210ea78

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7d7c3210ea78