1132682 - Convert Mozmill test 'remote/testSecurity/testMixedContentPage.js' to Marionette

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, defect, P1)

Description

[Barbara Miller (:galgeek)]

This bug will cover the necessary work to convert the following test into Marionette.

http://hg.mozilla.org/qa/mozmill-tests/file/default/firefox/tests/remote/testSecurity/testMixedContentPage.js

Comment 1

[om.bhallamudi]

Attachment: Github Pull request

I have converted this test to marionette. Could you please review this and tell me what changes are necessary?

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8567248 [details] [review]
Github Pull request

this passes all tests, the code seems to do what the original test does.  If there is some specific code style or way to do something in marionette that I am unaware of, maybe chmanchester can help out.  

A great first pull request.

Comment 3

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8567248 [details] [review]
Github Pull request

Looking good. I had one more note in github about adding a wait. Please flag me for review again when that's updated so I can have a final look. Thanks!

Comment 4

[om.bhallamudi]

Attachment: recreate PR

I have added another wait as you have suggested

Comment 5

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8567376 [details] [review]
recreate PR

This looks good. Thanks for your work on this!

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 8567248 [details] [review]
Github Pull request

Usually there is no need to re-create a PR. You can fixup your local branch and re-push with the -f (force) option.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I gave some more comments on the PR.

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

We have a pull request for this:
https://github.com/mozilla/firefox-ui-tests/pull/99

it is just having issues with a merge conflict!  Can we get that resolved or else find someone to get it merging?

Comment 9

[om.bhallamudi]

I have updated the pull request with the new methods that were introduced recently and removed all merge conflicts.

Comment 10

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8567376 [details] [review]
recreate PR

I had a question in the PR about something that changed since I last looked at this. Let's have a final review from :whimboo.

Comment 11

[Barbara Miller (:galgeek)]

Attachment: github pull request

This is mainly Om's work. I had a few minutes to finish it up today, and I don't see any response from Om to a comment I made on github a week or so ago, so Om is likely otherwise occupied.

Comment 12

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8594147 [details] [review]
github pull request

Two nits, but looks good, and all the comments from the previous review were addressed.

Comment 13

[Chris Manchester (limited bugmail, email directly)]

https://github.com/mozilla/firefox-ui-tests/commit/94ad3c750e58a2eddfbd00c64daf4fb619775ebd