Closed Bug 1132706 Opened 5 years ago Closed 5 years ago

Redesign the way we handle invalidation in the NewObjectCache

Categories

(Core :: JavaScript: GC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38
Tracking Status
firefox38 --- fixed

People

(Reporter: terrence, Assigned: terrence)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Currently, we're manually checking the GC number. Given that it's on the slow path, we might as well just re-do the hash, rather than relying on gcNumber.
Blocks: 1132286
No longer blocks: 1130211
Blocks: 1130211
No longer blocks: 1132286
Depends on: 1132286
Attached patch 0_rehash_for_cache-v0.diff (obsolete) — Splinter Review
Does this look reasonable?
Attachment #8563765 - Flags: review?(jcoppeard)
Comment on attachment 8563765 [details] [diff] [review]
0_rehash_for_cache-v0.diff

Nope, there's got to be something wrong with it, cause it seems we're not actually using the cache with it applied.
Attachment #8563765 - Flags: review?(jcoppeard)
Derp, I was checking the output of lookup before inserting, which is always going to be false.

FWIW, the stats I'm seeing on octane are:
Lookups/Insertions: 72055651 / 907606 => 79.3909
Hits/Lookups: 71147476 / 72055651 => 0.987396 hit rate
Misses/Lookups: 908175 / 72055651 => 0.012604 miss rate

Disabling the new object cache reduces our octane score by about 3%, so it's definitely still being effective.
Attachment #8564301 - Flags: review?(jcoppeard)
Comment on attachment 8564301 [details] [diff] [review]
0_rehash_for_cache-v1.diff

Review of attachment 8564301 [details] [diff] [review]:
-----------------------------------------------------------------

Great, that's much better.
Attachment #8564301 - Flags: review?(jcoppeard) → review+
Attachment #8563765 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/10237dc3ac66
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.