1132708 - Convert Mozmill test 'remote/testSecurity/testUntrustedConnectionErrorPage.js' to Marionette

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, defect, P1)

Description

[Barbara Miller (:galgeek)]

This bug will cover the necessary work to convert the following test into Marionette.

http://hg.mozilla.org/qa/mozmill-tests/file/default/firefox/tests/remote/testSecurity/testUntrustedConnectionErrorPage.js

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Some things to note here:

* When loading the given URL we expect a MarionetteException given that it is an about:error page

* The "getMeOutOfHereButton" can be retrieved via the content scope

* Before you are able to click on the button, you will have to wait about 1s. That's something magic with about:error pages, which we never figured out exactly in Mozmill:

https://github.com/mozilla/mozmill/blob/master/mozmill/mozmill/extension/resource/modules/windows.js#L194

Comment 2

[om.bhallamudi]

I will work on converting this test to Marionette

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thanks a lot! Let me know if you need more information in how to get started.

Comment 4

[om.bhallamudi]

Attachment: patch for bugfix

I have written the code and created a pull request. Could you review this for me?

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8565500 [details] [review]
patch for bugfix

I added a couple of comments to the code on the PR. Please have a look at those and ask if something is unclear.

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

Hi Om,

I see a pull request for this:
https://github.com/mozilla/firefox-ui-tests/pull/89

It looks like it has a small tweak so it can be landed.  Om, can you look at fixing this or let us know if you can't get to it so we can work on resolving this issue!

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

No reply from Om, given that is a P1 and we have to get this finished soon, we should tackle the remaining bits ourselves. I'm pulling this off from mentored bugs.

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

Attachment: https://github.com/mozilla/firefox-ui-tests/pull/133

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8579989 [details] [review]
https://github.com/mozilla/firefox-ui-tests/pull/133

I made a couple of comments on the PR, which need to be fixed. Let me know if something is unclear.

Comment 10

[Barbara Miller (:galgeek)]

Attachment: github_pull_request.txt

This PR simply removes the now, I believe, unnecessary edits to test_security_notification.py present in PR 133.

Comment 11

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8586514 [details] [review]
github_pull_request.txt

This looks great. One small clean up noted in github.

Comment 12

[Barbara Miller (:galgeek)]

Thanks for your review, Chris!

I've updated the PR.

Comment 13

[Chris Manchester (limited bugmail, email directly)]

https://github.com/mozilla/firefox-ui-tests/commit/91c0c2322790770ddf1e85bd2ff3d7489648301b