Convert Mozmill test 'remote/testSecurity/testUntrustedConnectionErrorPage.js' to Marionette

RESOLVED FIXED in mozilla40

Status

Testing
Firefox UI Tests
P1
normal
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: galgeek, Assigned: galgeek)

Tracking

(Blocks: 1 bug)

unspecified
mozilla40
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [lang=py], URL)

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

3 years ago
This bug will cover the necessary work to convert the following test into Marionette.

http://hg.mozilla.org/qa/mozmill-tests/file/default/firefox/tests/remote/testSecurity/testUntrustedConnectionErrorPage.js
(Assignee)

Updated

3 years ago
Blocks: 1132629
Priority: -- → P1
Some things to note here:

* When loading the given URL we expect a MarionetteException given that it is an about:error page

* The "getMeOutOfHereButton" can be retrieved via the content scope

* Before you are able to click on the button, you will have to wait about 1s. That's something magic with about:error pages, which we never figured out exactly in Mozmill:

https://github.com/mozilla/mozmill/blob/master/mozmill/mozmill/extension/resource/modules/windows.js#L194
Mentor: hskupin@gmail.com
Whiteboard: [lang=py]

Comment 2

3 years ago
I will work on converting this test to Marionette
Thanks a lot! Let me know if you need more information in how to get started.
Assignee: nobody → om.bhallamudi
Status: NEW → ASSIGNED

Comment 4

3 years ago
Created attachment 8565500 [details] [review]
patch for bugfix

I have written the code and created a pull request. Could you review this for me?
Attachment #8565500 - Flags: review?(hskupin)
Comment on attachment 8565500 [details] [review]
patch for bugfix

I added a couple of comments to the code on the PR. Please have a look at those and ask if something is unclear.
Attachment #8565500 - Flags: review?(hskupin) → review-
Hi Om,

I see a pull request for this:
https://github.com/mozilla/firefox-ui-tests/pull/89

It looks like it has a small tweak so it can be landed.  Om, can you look at fixing this or let us know if you can't get to it so we can work on resolving this issue!
Flags: needinfo?(om.bhallamudi)
No reply from Om, given that is a P1 and we have to get this finished soon, we should tackle the remaining bits ourselves. I'm pulling this off from mentored bugs.
Assignee: om.bhallamudi → nobody
Mentor: hskupin@gmail.com
Status: ASSIGNED → NEW
Flags: needinfo?(om.bhallamudi)
Created attachment 8579989 [details] [review]
https://github.com/mozilla/firefox-ui-tests/pull/133
Assignee: nobody → jmaher
Attachment #8565500 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #8579989 - Flags: review?(hskupin)
Comment on attachment 8579989 [details] [review]
https://github.com/mozilla/firefox-ui-tests/pull/133

I made a couple of comments on the PR, which need to be fixed. Let me know if something is unclear.
Attachment #8579989 - Flags: review?(hskupin) → feedback+
Attachment #8579989 - Flags: review?
(Assignee)

Comment 10

3 years ago
Created attachment 8586514 [details] [review]
github_pull_request.txt

This PR simply removes the now, I believe, unnecessary edits to test_security_notification.py present in PR 133.
Attachment #8579989 - Attachment is obsolete: true
Attachment #8579989 - Flags: review?
Attachment #8586514 - Flags: review?(hskupin)
(Assignee)

Updated

3 years ago
Attachment #8586514 - Flags: review?(hskupin) → review?(cmanchester)
Comment on attachment 8586514 [details] [review]
github_pull_request.txt

This looks great. One small clean up noted in github.
Attachment #8586514 - Flags: review?(cmanchester) → review+
(Assignee)

Comment 12

3 years ago
Thanks for your review, Chris!

I've updated the PR.
https://github.com/mozilla/firefox-ui-tests/commit/91c0c2322790770ddf1e85bd2ff3d7489648301b
Assignee: jmaher → galgeek
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 40
Product: Mozilla QA → Testing
You need to log in before you can comment on or make changes to this bug.