1132709 - Convert Mozmill test 'remote/testSecurity/testUnknownIssuer.js' to Marionette

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, defect, P1)

Description

[Barbara Miller (:galgeek)]

This bug will cover the necessary work to convert the following test into Marionette.

http://hg.mozilla.org/qa/mozmill-tests/file/default/firefox/tests/remote/testSecurity/testUnknownIssuer.js

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Some things to note here:

* When loading the given URL we expect a MarionetteException given that it is an about:error page

* Any element of this page can be retrieved via the content scope

* Before you are able to interact with the elements you will have to wait about 1s. That's something magic with about:error pages, which we never figured out exactly in Mozmill:

https://github.com/mozilla/mozmill/blob/master/mozmill/mozmill/extension/resource/modules/windows.js#L194

Comment 2

[Barbara Miller (:galgeek)]

Attachment: github_pull_request.txt

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8566897 [details] [review]
github_pull_request.txt

Functionality wise this looks fine. I made some comments which need to be fixed.

Comment 4

[Barbara Miller (:galgeek)]

Comment on attachment 8566897 [details] [review]
github_pull_request.txt

Thank you for your feedback, Henrik!

I've updated the PR per your comments.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8566897 [details] [review]
github_pull_request.txt

r- mostly because of the context handling, which worries me a bit. We should ensure to stay in chrome context when entering teardown.

Comment 6

[Barbara Miller (:galgeek)]

Comment on attachment 8566897 [details] [review]
github_pull_request.txt

Thanks for your feedback!

I've updated the PR.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 8566897 [details] [review]
github_pull_request.txt

Looks good! It only needs a rebase. Once that is done we can get it landed.

Comment 8

[Chris Manchester (limited bugmail, email directly)]

https://github.com/mozilla/firefox-ui-tests/commit/ab89a5f793afd15f1f7893bcd9cb4d68a5613c3a