[Stingray] Fix localizeElement in tv shared utils

RESOLVED FIXED

Status

Firefox OS
Gaia::TV::System
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: chens, Assigned: chens)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
This is a follow up of bug 1123184, mozL10n should use `setAttributes` instead of `setAttribute`.
Created attachment 8563847 [details] [review]
[gaia] shamenchens:Bug1132775-FixLocalizedElements > mozilla-b2g:master
Comment hidden (obsolete)
(Assignee)

Comment 3

4 years ago
Comment on attachment 8563847 [details] [review]
[gaia] shamenchens:Bug1132775-FixLocalizedElements > mozilla-b2g:master

Hi John, 

This patch fixes mozL10n API usage [1], could you review this? thanks!

[1] https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/localization_code_best_practices#Writing_APIs_that_operate_on_L10nIDs
Attachment #8563847 - Flags: review?(im)
(Assignee)

Updated

4 years ago
Attachment #8563851 - Attachment is obsolete: true
Attachment #8563851 - Flags: review?(im)
Comment on attachment 8563847 [details] [review]
[gaia] shamenchens:Bug1132775-FixLocalizedElements > mozilla-b2g:master

looks good to me.
Attachment #8563847 - Flags: review?(im) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed

Updated

4 years ago
Keywords: checkin-needed

Updated

4 years ago
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.