Closed
Bug 1132775
Opened 11 years ago
Closed 11 years ago
[Stingray] Fix localizeElement in tv shared utils
Categories
(Firefox OS Graveyard :: Gaia::TV::System, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: chens, Assigned: chens)
Details
(Whiteboard: [ft:conndevices])
Attachments
(1 file, 1 obsolete file)
This is a follow up of bug 1123184, mozL10n should use `setAttributes` instead of `setAttribute`.
|
||
Comment 1•11 years ago
|
||
| Comment hidden (obsolete) |
|
Assignee | |
Comment 3•11 years ago
|
||
Comment on attachment 8563847 [details] [review]
[gaia] shamenchens:Bug1132775-FixLocalizedElements > mozilla-b2g:master
Hi John,
This patch fixes mozL10n API usage [1], could you review this? thanks!
[1] https://developer.mozilla.org/en-US/Firefox_OS/Developing_Gaia/localization_code_best_practices#Writing_APIs_that_operate_on_L10nIDs
Attachment #8563847 -
Flags: review?(im)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8563851 -
Attachment is obsolete: true
Attachment #8563851 -
Flags: review?(im)
|
||
Comment 4•11 years ago
|
||
Comment on attachment 8563847 [details] [review]
[gaia] shamenchens:Bug1132775-FixLocalizedElements > mozilla-b2g:master
looks good to me.
Attachment #8563847 -
Flags: review?(im) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
|
||
Updated•11 years ago
|
Keywords: checkin-needed
|
|
||
Comment 5•11 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/979e6adbc5159001f6dd208e1bd3ff6e6dce06d4
|
|
||
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•