[EME] ClearKey doesn't work on MacOSX

RESOLVED FIXED in Firefox 38

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: cpearce, Assigned: cpearce)

Tracking

(Blocks: 1 bug)

unspecified
mozilla38
x86
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox38 fixed)

Details

Attachments

(1 attachment)

http://people.mozilla.org/~cpearce/mse-clearkey does not work on MacOSX, we get a "not supported error".

This is because the GMPService::AddPluginDir is being called with the wrong path for ClearKey.

In a local build on our mach Mini AddPluginDir is being called with:
/Users/cpearce/src/m-c/obj-x86_64-apple-darwin12.5.0/dist/Nightly.app/Contents/MacOS/gmp-clearkey/0.1

But the CDM resides in:
/Users/cpearce/src/m-c/obj-x86_64-apple-darwin12.5.0/dist/Nightly.app/Contents/Resources/gmp-clearkey/0.1

Setting the environment variable MOZ_GMP_PATH to the latter makes ClearKey work.

We really need to get this fixed, even though it's not blocking the Adobe EME MVP; a lot of our devs work on MacOSX, and a lot of people test on MacOSX, and I get several emails a week asking me why ClearKey doesn't work, and I have to use my psychic powers and tell them they must be running MacOSX and ClearKey doesn't work there.
(Assignee)

Comment 1

4 years ago
Created attachment 8563878 [details] [diff] [review]
Patch: Make ClearKey EME work on MacOSX

I know this isn't the fix you wanted for future versions of MacOSX, but it fixes EME for me on MacOSX, and it will stop people bugging me all the time about ClearKey not working on MacOSX.
Assignee: nobody → cpearce
Status: NEW → ASSIGNED
Attachment #8563878 - Flags: review?(spohl.mozilla.bugs)
(Assignee)

Comment 2

4 years ago
We should also try to remove the code that sets up gmp-clearkey in testing/mochitest/runtests.py, and rely on the GMP provider to setup the gmp plugin dir for mochitests. That way we capture regressions in packaging. In the short term however, I have to do a daycare run...
Comment on attachment 8563878 [details] [diff] [review]
Patch: Make ClearKey EME work on MacOSX

Review of attachment 8563878 [details] [diff] [review]:
-----------------------------------------------------------------

In its current form, this is the proper fix. So go ahead! :-)
Attachment #8563878 - Flags: review?(spohl.mozilla.bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/c81728bfda79
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-firefox38: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Blocks: 1134817
You need to log in before you can comment on or make changes to this bug.