1132818 - Fix -Wsometimes-uninitialized nsresult warning in security/nss/lib/smime/smimeutil.c

Status: RESOLVED FIXED

(NSS :: Libraries, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: Wsometimes-uninitialized_key_type.patch

key_type is uninitialized if CERT_ExtractPublicKey() returns null:

security/nss/lib/smime/smimeutil.c:440:10: warning: variable 'key_type' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]

Comment 1

[[:mmc] Monica Chew (no longer reading bugmail)]

Comment on attachment 8563945 [details] [diff] [review]
Wsometimes-uninitialized_key_type.patch

Review of attachment 8563945 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, Chris!

Comment 2

[Chris Peterson [:cpeterson]]

Monica, how do I land a patch in the NSS tree?

Comment 3

[[:mmc] Monica Chew (no longer reading bugmail)]

First, my bad for not noticing that this fix was in NSS and not PSM. Second, I'm not actually a PSM peer anyway! I think David can do this for you.

Comment 4

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

I think technically we need a non-Mozilla person to review this. In any case, I don't actually have commit access to NSS. Perhaps Kai can take care of this.

Comment 5

[Chris Peterson [:cpeterson]]

(In reply to [:mmc] Monica Chew (please use needinfo) from comment #3)
> First, my bad for not noticing that this fix was in NSS and not PSM. Second,
> I'm not actually a PSM peer anyway! I think David can do this for you.

I filed this bug in the Core::Security::PSM component because I didn't realize Bugzilla had a dedicated NSS product. (Thanks, Cykesiopka! :)

Comment 6

[:Cykesiopka]

No problem!

Comment 7

[Kai Engert (:kaie:)]

Comment on attachment 8563945 [details] [diff] [review]
Wsometimes-uninitialized_key_type.patch

r=kaie

Comment 8

[Kai Engert (:kaie:)]

https://hg.mozilla.org/projects/nss/rev/10c82beac914