1132819 - Upgrade jshint to 2.6.0 for supporting missing mocha keyword

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Ricky Chien [:rickychien] (inactive)]

JSHint 2.6.0 support missing mocha keywords suiteSetup and suiteTeardown, so that we can remove all /* global suiteSetup */ once we enable /* jshint mocha: true */.
See also [1] for further information.


[1] https://github.com/jshint/jshint/releases/tag/2.6.0

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] RickyChien:bug-1132819 > mozilla-b2g:master

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia-node-modules] RickyChien:Upgrade-jshint-2.6.0 > mozilla-b2g:master

Comment 3

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8563961 [details] [review]
[gaia] RickyChien:bug-1132819 > mozilla-b2g:master

Hi here is a simple patch for upgrading jshint for build scripts. Please take a look thanks!

Comment 4

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8563961 [details] [review]
[gaia] RickyChien:bug-1132819 > mozilla-b2g:master

r=gduan

Comment 5

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/8a7c5e2d4e7855be2d84fbe3385c4fad28db5a3e

Comment 6

[Kevin Grandon :kgrandon]

I would like to get jshint updated on v2.2 to 2.6 as well, but it's a bit of a pain because we never branched gaia-node-modules. We'd probably need to cut a 2.2 branch from the current sha on gaia to do so.

Comment 7

[Kevin Grandon :kgrandon]

v2.2 node-modules branched: https://github.com/mozilla-b2g/gaia-node-modules/tree/v2.2
Cherry-picked to v2.2 node-modules: https://github.com/mozilla-b2g/gaia-node-modules/commit/73a1fd8b2843c45b73eeafee5fb5aeea21046b53

Comment 8

[GitHub Autolander Bot]

Attachment: [gaia] KevinGrandon:bug_1132819_update_jshint_2_2 > mozilla-b2g:v2.2