Map settings "ril.debugging.enabled" to preference

RESOLVED FIXED in Firefox 39

Status

Firefox OS
RIL
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: aknow, Assigned: aknow)

Tracking

unspecified
2.2 S7 (6mar)
x86_64
Linux

Firefox Tracking Flags

(tracking-b2g:backlog, firefox39 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Now, we use preference "ril.debugging.enabled" for the purpose.  However, I found that bluetooth, wifi, nfc, ... all of them are using settings key "xxx.debugging.enabled" to toggle the log.

So, do we want to have this change: migrating from preference to settings?
blocking-b2g: --- → backlog
(Assignee)

Updated

4 years ago
Assignee: nobody → szchen
(Assignee)

Updated

4 years ago
Summary: Use settings key to toggle ril debugging log → Map settings "ril.debugging.enabled" to preference
(Assignee)

Comment 1

4 years ago
Created attachment 8565267 [details] [diff] [review]
Map settings "ril.debugging.enabled" to preference

Just map settings to preference.  We don't have to modify the existing logging logic.
Attachment #8565267 - Flags: review?(htsai)

Updated

3 years ago
Attachment #8565267 - Flags: review?(htsai) → review+
This should have been added to the list at https://mxr.mozilla.org/mozilla-central/source/b2g/chrome/content/settings.js#486 instead.

Please ask review to the correct peer next time.
https://hg.mozilla.org/mozilla-central/rev/eb855de76fbe
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S7 (6mar)
(Assignee)

Updated

3 years ago
Blocks: 1137048
blocking-b2g: backlog → ---
tracking-b2g: --- → backlog
You need to log in before you can comment on or make changes to this bug.