Closed
Bug 1132893
Opened 9 years ago
Closed 9 years ago
Move the Builds4hAnalyzer blacklist inline
Categories
(Tree Management :: Treeherder: Data Ingestion, defect, P3)
Tree Management
Treeherder: Data Ingestion
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
References
Details
Broken out of bug 1066266 : https://github.com/mozilla/treeherder-service/pull/371#issuecomment-74246661 > I just noticed we have some versioned content in media: > https://github.com/mozilla/treeherder-service/blob/master/treeherder/webapp/media/builds4hanalysis/blacklist.json > It simply shouldn't be there. Looking at 1d3631b it looks like we only read it and it > contains a balcklist of buildernames, but I don't know > 1)why it was put in a json file instead of a python module and > 2)why it's there instead of being in static/
Comment 1•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder-service https://github.com/mozilla/treeherder-service/commit/cf06199a67bde8cbaa626cc5c8fc83d8d00b2be8 Bug 1132893 - Move the Builds4hAnalyzer blacklist inline A json file is overkill, and it is currently in a directory intended for production-specific files, so move the blacklist inline. We should probably move the whole analyser to another file, but that can be done later. Also store the analyser output in the root of the media directory, since a subdirectory is unnecessary. The media directory is now empty, so we must use .gitkeep to ensure it is created.
Assignee | ||
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•