1132897 - avatar picture with Netsoul account

Status: RESOLVED FIXED

(Chat Core :: Netsoul, defect)

Description

[Thibault]

Attachment: issue_netsoul_screenshot.png

User Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/40.0.2214.111 Safari/537.36

Steps to reproduce:

1. Open Instantbird
2. Wait "instantbird" connect to Netsoul
3. The contact list is printed : double click on a contact
4. Dialog window open and the avatar picture area is empty.


Actual results:

The contact picture area is empty.


Expected results:

The contact picture must be show in this area.

Replace the old http(s) URL with the new one (http://cdn.epitech.net/userprofil/profilview/<contact_login>.jpg) to get contact picture working.

The new address only listen on HTTP.

Comment 1

[Florian Quèze [:florian]]

Thanks for the bug report! Would you like to provide a patch? The URL is defined at https://hg.mozilla.org/users/florian_queze.net/purple/file/00eadc03a66a/libpurple/protocols/netsoul/netsoul.h#l69

Comment 2

[Thibault]

Ok, i will patch this issue.
 
I need to create an account to push modification on the mercurial repos ?

Comment 3

[Florian Quèze [:florian]]

(In reply to Thibault from comment #2)

> I need to create an account to push modification on the mercurial repos ?

You don't need an account, you just create a patch, and attach it in the bug here.

Comment 4

[Thibault]

Attachment: patch.diff

Comment 5

[Florian Quèze [:florian]]

Comment on attachment 8564261 [details] [diff] [review]
patch.diff

Review of attachment 8564261 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks for the patch! :-)

Comment 6

[Florian Quèze [:florian]]

https://hg.mozilla.org/users/florian_queze.net/purple/rev/18e35a43ad30

Comment 7

[Patrick Cloke [:clokep]]

Should we upstream this anywhere? I forget where the netsoul code even comes from...or is it one of those ones that was forked 40 times?

Comment 8

[Florian Quèze [:florian]]

(In reply to Patrick Cloke [:clokep] from comment #7)
> Should we upstream this anywhere? I forget where the netsoul code even comes
> from...or is it one of those ones that was forked 40 times?

We initially got the code for this plugin from the gaim-netsoul project on sourceforge in 2007.

The homepage of the project (http://sourceforge.net/projects/gaim-netsoul/) says " Last Update: 2013-04-17 ", but the most recent file is dated from 2007-06-12. The most recent check-in in the source code (http://sourceforge.net/p/gaim-netsoul/code/HEAD/tree/) seems to be dated 2007-11-06.

It seems there's a newer fork at https://code.google.com/p/netsoul-pidgin/, where everything is dated "Apr 21, 2010" (only one revision in the code repository).

So... I'm afraid we are the 'upstream' at this point.