Move hyperlink auditing code out of nsDocShell.cpp

NEW
Unassigned

Status

()

Core
Document Navigation
3 years ago
3 years ago

People

(Reporter: ttaubert, Unassigned)

Tracking

(Blocks: 1 bug)

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
nsDocShell.cpp is big enough already and we can easily extract that feature.
(Reporter)

Comment 1

3 years ago
Created attachment 8564172 [details] [diff] [review]
0001-Bug-1132933-Move-a-ping-code-out-of-nsDocShell.cpp.patch

Thought it would be a good idea to clean up before addressing the missing checks to get it enabled by default.
Assignee: nobody → ttaubert
Status: NEW → ASSIGNED
Attachment #8564172 - Flags: review?(bzbarsky)
(Reporter)

Comment 2

3 years ago
Not entirely sure about whether dom/html and mozilla::dom:: is the right place for that code but that's where the <a ping> tests have moved since I added them.
Comment on attachment 8564172 [details] [diff] [review]
0001-Bug-1132933-Move-a-ping-code-out-of-nsDocShell.cpp.patch

So typically mozilla/dom/AnchorPing.h and mozilla::dom::AnchorPing would correspond to a Web IDL interface called AnchorPing, which is very much not the case here.

At the very least, we should not export the header.

In terms of the actual vcs mechanics, I think it would be better to preserve blame by doing an hg cp and deleting the non-ping bits instead of copying the ping stuff manually (and reordering it in the process).
Attachment #8564172 - Flags: review?(bzbarsky) → review-
(Reporter)

Comment 4

3 years ago
I probably won't ever get to this, sorry.
Assignee: ttaubert → nobody
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.